Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Network module: Network connected but no internet format #1487

Open
mizzunet opened this issue Mar 17, 2022 · 1 comment · May be fixed by #2372
Open

[Feature] Network module: Network connected but no internet format #1487

mizzunet opened this issue Mar 17, 2022 · 1 comment · May be fixed by #2372

Comments

@mizzunet
Copy link

mizzunet commented Mar 17, 2022 •
edited

It would be quite handy to have indicator for network (wlan or eth) is connected but no internet.

I think, it can be achieved by running ping whenever,

  1. For specified interval
  2. Once network is connected

So, the config to be like,

"network": {
...
    "format-nointernet": {
                  "wifi": "No Internet",
                  "lan": "No internet",
     },
    "ping-interval": "30",
..
}
@mizzunet mizzunet changed the title network module: network connected but no internet [Feature] Network module: network connected but no internet Mar 17, 2022
@mizzunet mizzunet changed the title [Feature] Network module: network connected but no internet [Feature] Network module: Network connected but no internet format Mar 17, 2022
@Absobel
Copy link

Absobel commented Aug 1, 2023

I checked the code, I'd be down to try implementing it (also i need this functionality hehe). What would be the best way of implementing it ? Would a thread that wakes up every ping-interval seconds to ping a list of servers from an eventual "servers" key in the config be fine ?

@Absobel Absobel linked a pull request Aug 1, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Feature] Network module: Network connected but no internet format Absobel/Waybar
2 participants
@mizzunet @Absobel