-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spawn first rail when chunk_0_0 unloaded #525
base: master
Are you sure you want to change the base?
Spawn first rail when chunk_0_0 unloaded #525
Conversation
I think this solution is only fixing a symptom and not the core bug while introducing undeterministic save behaviour (we already have some but I want to get red of that completely because it creates versioning noise and easily breakes your maps) |
CC @DasCapschen |
I'm not sure, but wouldn't using the camera origin mean that track objects could end up in the wrong chunk? Especially if the camera is in one chunk and the rail in another, e.g. due to being close to a chunk's edge? If I understand correctly, the issue is that the rail origin may not be set (e.g. is 0,0,0). The function Here's an example of var rail2: Node = _spawn_rail()
rail2.translation = selected_object.end_pos
rail2.start_pos = selected_object.end_pos
rail2.rotation.y = selected_object.end_rot
rail2.start_rot = selected_object.end_rot
rail2.radius = 0
rail2.length = y_length - x_length
rail2.update() Perhaps we should adjust |
This is a valid remark, let me dig into this |
I'm with @nalquas on this one. There's an Edge Case also, which I'm not sure is currently covered:
|
@DasCapschen I thought it's done on save already? Or do I confuse that with the chunk manager and the conversion? |
Fixes #438
Steps to reproduce:
Core reason is that preloaded rail origin is used and it lead to chunk which is not available.
Proposal is to use current camera origin right away.