Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creation of rails fails far away from (0,0,0) crashes editor #438

Open
Jean28518 opened this issue Nov 27, 2022 · 3 comments · May be fixed by #525
Open

Creation of rails fails far away from (0,0,0) crashes editor #438

Jean28518 opened this issue Nov 27, 2022 · 3 comments · May be fixed by #525
Labels
bug Something isn't working crash Crashes Godot and thus is a very important issue. editor everthing that belongs to the editor functions of Libre TrainSim
Projects
v0.9
Milestone
0.9

Comments

@Jean28518
Copy link
Member

If the position (0,0,0) is in a unloaded chunk, the creation of new rails crashes.

At the time of the referencing rail.global_transform.origin the value is (0,0,0)

grafik
@Jean28518 Jean28518 added bug Something isn't working editor everthing that belongs to the editor functions of Libre TrainSim Priority:High labels Nov 27, 2022
@Jean28518 Jean28518 changed the title Creation of rails fails far away from (0,0,0) Creation of rails fails far away from (0,0,0) crashes editor Nov 27, 2022
@Jean28518 Jean28518 added this to the 0.9 milestone Dec 4, 2022
@HaSa1002
Copy link
Member

Can't reproduce.

@HaSa1002 HaSa1002 added crash Crashes Godot and thus is a very important issue. and removed Priority:High labels Dec 27, 2022
@HaSa1002
Copy link
Member

Issue may be specific to Hainfurt. Rail creation fails due to non existent TrackObjects node. May be related to these errors:

[2023-01-29 00:20:13][WARNING](MultiMeshInstance:[MultiMeshInstance:2026742]) Unknown object type encountered!
	At: res://Editor/Scripts/Editor.gd:831:get_type_of_object()
	At: res://Editor/Scripts/Editor.gd:638:handle_drag_mode()

Full log while fixing rail transitions
438-repro.log

@nalquas nalquas added this to To do in v0.9 via automation Feb 27, 2023
custodian added a commit to custodian/Libre-TrainSim that referenced this issue Aug 10, 2023
@custodian
Fixes Libre-TrainSim#438 Spawn first rail when chunk_0_0 unloaded
ee7dec4
@custodian
Copy link
Contributor

Steps to reproduce:

  1. Create new world
  2. Move camera away from chunk_0_0 so it unloads (i.e. to 4 0 with visibility of 2 chunks)
  3. Save world
  4. Load world. Move further 1 chunk to trigger chunk_0_0 loaded by default to unload
  5. Try to place first rail within the map

@custodian custodian linked a pull request Aug 10, 2023 that will close this issue
Draft
@DasCapschen DasCapschen moved this from To do to In progress in v0.9 Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working crash Crashes Godot and thus is a very important issue. editor everthing that belongs to the editor functions of Libre TrainSim
Projects
v0.9
  
In progress
Milestone
0.9
Development

Successfully merging a pull request may close this issue.

Spawn first rail when chunk_0_0 unloaded custodian/Libre-TrainSim
3 participants
@custodian @HaSa1002 @Jean28518