New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tech debt] Improve interface for RandomSunFlare #1631

Open

ternaus opened this issue Apr 5, 2024 · 0 comments

Labels

good first issue Tech debt

Collaborator

ternaus commented Apr 5, 2024 •

edited

Right now in the transform we have separate parameters for angle_lower, angle_upper, num_flare_circles_lower, num_flare_circles_upper

Better would be to have:

num_flare_circles_range= [num_flare_circles_lower, num_flare_circles_upper]
angle_range = [angle_lower, angle_higher]

=>

We can update transform to use new signature, keep old as working, but mark as deprecated.

PR could be similar to #1704

The text was updated successfully, but these errors were encountered:

ternaus added good first issue Tech debt labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment