Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tech debt] Improve interface for GridDropOut #1634

Open
ternaus opened this issue Apr 5, 2024 · 0 comments
Open

[Tech debt] Improve interface for GridDropOut #1634

ternaus opened this issue Apr 5, 2024 · 0 comments
Labels

Comments

@ternaus
Copy link
Collaborator

ternaus commented Apr 5, 2024

  • unit_size_min, unit_size_max => unit_size_range
  • shift_x, shift_y => shift

=>

We can update transform to use new signature, keep old as working, but mark as deprecated.

PR could be similar to #1704

@ternaus ternaus added good first issue Good for newcomers Tech debt labels Apr 5, 2024
@ternaus ternaus changed the title [Code quality] Improve interface for GridDropOut [Tech debt] Improve interface for GridDropOut Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant