Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make keyboard binding implicit / remove ability to bind to any element #661

Open
nikku opened this issue Aug 15, 2022 · 2 comments · May be fixed by #662
Open

Make keyboard binding implicit / remove ability to bind to any element #661

nikku opened this issue Aug 15, 2022 · 2 comments · May be fixed by #662
Assignees
@nikku
Labels
backlog Queued in backlog enhancement New feature or request

Comments

@nikku
Copy link
Member

nikku commented Aug 15, 2022 •
edited

Is your feature request related to a problem? Please describe.

For historical reasons our users had to bind keyboard to any element on the page, may it be document, or the diagram container. With #662 we make the diagram canvas browser selectable; as such we can safely figure out if the canvas has focus and keyboard bindings shall be accounted for.

Because of that we want to remove the bind anywhere keyboard#bindTo / keyboard#bind(element) APIs.

Describe the solution you'd like

  • Keyboard can be bound and unbound, however it will always be bound to the canvas
  • Binding keyboard to a particular element is removed
  • Configuring element to be bound to via keyboard.bindTo is removed
  • Proper error messages indicate old use

Describe alternatives you've considered

Keep stuff and magic as is.

Additional context

This is a major improvement UX wise.
@nikku nikku added the enhancement New feature or request label Aug 15, 2022
@nikku nikku changed the title Remove ability to bind keyboard to any element Bind keyboard implicitly / remove ability to bind to any element Aug 15, 2022
@nikku nikku changed the title Bind keyboard implicitly / remove ability to bind to any element Make keyboard binding implicit / remove ability to bind to any element Aug 15, 2022
@nikku nikku linked a pull request Aug 15, 2022 that will close this issue
Draft
@nikku nikku added the ready Ready to be worked on label Aug 17, 2022 — with bpmn-io-tasks
@nikku nikku self-assigned this Aug 17, 2022
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed ready Ready to be worked on labels Aug 18, 2022
@nikku nikku added the backlog Queued in backlog label Aug 19, 2022 — with bpmn-io-tasks
@nikku nikku removed the in progress Currently worked on label Aug 19, 2022
@nikku nikku removed their assignment Aug 19, 2022
@nikku nikku mentioned this issue Dec 4, 2022
Draft
@nikku nikku added the ready Ready to be worked on label Jan 30, 2024 — with bpmn-io-tasks
@nikku nikku removed the backlog Queued in backlog label Jan 30, 2024
@marstamm
Copy link
Contributor

@nikku , assigned to you for now to clarify what is needed to enable HTO team

@nikku
Copy link
Member Author

nikku commented Mar 1, 2024

@vsgoulart I'll not be able to follow up on this in the next days, but will revisit end of March.

@nikku nikku added backlog Queued in backlog and removed ready Ready to be worked on labels Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nikku nikku

Labels
backlog Queued in backlog enhancement New feature or request
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make canvas selectable / keyboard binding implicit bpmn-io/diagram-js
2 participants
@nikku @marstamm