Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(popup-menu): allow grouping header entries #900

Merged
merged 1 commit into from
May 22, 2024
Merged

feat(popup-menu): allow grouping header entries #900

merged 1 commit into from
May 22, 2024

Conversation

philippfromme
Copy link
Contributor

@philippfromme philippfromme commented May 16, 2024 •
edited

Try out via

npx @bpmn-io/sr bpmn-io/bpmn-js#popup-menu-header-entry-groups-example -l bpmn-io/diagram-js#popup-menu-header-entry-groups

brave_h88fABOpo3

Closes #896

@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label May 16, 2024
@philippfromme philippfromme force-pushed the popup-menu-header-entry-groups branch from 9e3d5b1 to 4e963bd Compare May 16, 2024 12:25
@nikku
Copy link
Member

nikku commented May 16, 2024

How can I try this E2E? 🙂

@philippfromme
Copy link
Contributor Author

How can I try this E2E? 🙂

npx @bpmn-io/sr bpmn-io/bpmn-js#popup-menu-header-entry-groups-example -l bpmn-io/diagram-js#popup-menu-header-entry-groups

@philippfromme philippfromme marked this pull request as ready for review May 16, 2024 12:32
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels May 16, 2024
@philippfromme philippfromme force-pushed the popup-menu-header-entry-groups branch 3 times, most recently from e8b7db2 to a446946 Compare May 22, 2024 07:41
nikku
nikku reviewed May 22, 2024
View reviewed changes
assets/diagram-js.css Outdated Show resolved Hide resolved
@philippfromme philippfromme force-pushed the popup-menu-header-entry-groups branch from a446946 to 216bb4d Compare May 22, 2024 08:48
@philippfromme philippfromme requested a review from nikku May 22, 2024 09:00
nikku
nikku approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement. Cool to see header and body entries are now en par.

@philippfromme philippfromme merged commit 1ba9142 into develop May 22, 2024
11 of 12 checks passed
@philippfromme philippfromme deleted the popup-menu-header-entry-groups branch May 22, 2024 09:05
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label May 22, 2024
This was referenced May 22, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikku nikku nikku approved these changes

@marstamm marstamm Awaiting requested review from marstamm

@barmac barmac Awaiting requested review from barmac

Assignees

@philippfromme philippfromme

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support grouping of popup menu header entries
2 participants
@philippfromme @nikku