Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

card #32392

Closed
2 of 9 tasks
sshane opened this issue May 11, 2024 · 0 comments
Closed
2 of 9 tasks

card #32392

sshane opened this issue May 11, 2024 · 0 comments

Comments

@sshane
Copy link
Contributor

sshane commented May 11, 2024

each bullet point should be shippable on its own

  • move everything car-related to card:
    • move all car events to card such as pedal pressed, need to read ndog param.
    • move all lateral and long controllers to card
    • v cruise manager
    • add a very simple state machine for only car-specific events
      • This solves safety mismatch issues such as controlsd dropping a button cancel event and not disengaging while panda puts controlsAllowed low. card publishes something like carState.enabled which controlsd's larger state machine should take into account, along with non-car-specific events like DM or device-related
    • v cruise
  • run in testing closet to ensure consistent timings
  • enable as a separate process

I tried a project, but I like this discussion format better!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant