Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APK files might get corrupted on upload #1549

Open
licaon-kter opened this issue Feb 2, 2024 · 1 comment
Open

APK files might get corrupted on upload #1549

licaon-kter opened this issue Feb 2, 2024 · 1 comment

Comments

@licaon-kter
Copy link
Contributor

Dino 7e3ceda Linux amd64
ejabberd 23.10+commits Linux arm64

file: org.woheller69.whobird_15.apk.ZIP (remove .ZIP from name)

sha256sum: a543a0f8949e4ff94121d3c3583bf97b0bd7e46ce9b4a8100eb829d5fc8c403e
original size: 17228300

Dino uploads (OMEMO):

<iq id='9bc68607-d5fc-442a-ad87-00024ea35145' type='get' to='upload.mydomain.tld'>
  <request xmlns='urn:xmpp:http:upload:0' filename='org.woheller69.whobird_15.apk' size='17165466' content-type='application/octet-stream' />
</iq>

On server size: 17165466

Dino uploads (unencrypted):

<iq id='a1f5d80f-d7c1-44d6-baea-27a75d274d46' type='get' to='upload.mydomain.tld'>
  <request xmlns='urn:xmpp:http:upload:0' filename='org.woheller69.whobird_15.apk' size='17165450' content-type='application/vnd.android.package-archive' />
</iq>

On server size: 17165450

Contact downloads the file (can repro, always the same sha256sum!)

sha256sum: a3d68e1609c43135ff1e4f3c0a013ec3399f1b9828f90cd38c3273da7f61ef17
size: 17165450

Uploads from Conversations work fine.

I'm uploading APKs daily, this is the first time one become un-installable, not sure others were affected.

@licaon-kter licaon-kter changed the title Sent files might get corrupted APK files might get corrupted on upload Feb 2, 2024
@licaon-kter
Copy link
Contributor Author

licaon-kter commented Feb 2, 2024

Amended title

Sending the same file w/ OMEMO but with .ZIP added to the name:

<iq id='b5811c89-1431-45ba-b5ec-c9e80fcd5a61' type='get' to='upload.mydomain.tld'>
  <request xmlns='urn:xmpp:http:upload:0' filename='org.woheller69.whobird_15.apk.ZIP' size='17228316' content-type='application/octet-stream' />
</iq>

...file size is correct (+16 from OMEMO)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant