Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transitions: name sometimes overlaps with other elements #2900

Open
1 of 3 tasks
ebousse opened this issue Dec 5, 2023 · 3 comments
Open
1 of 3 tasks

Transitions: name sometimes overlaps with other elements #2900

ebousse opened this issue Dec 5, 2023 · 3 comments
Labels
feature A new feature

Comments

@ebousse
Copy link

ebousse commented Dec 5, 2023

Describe the bug

In a state machine diagram, it sometimes happens that transition names are overlapping other graphical elements, making them unreadable.

(This is a similar issue as this older one: #2025)

To Reproduce

Steps to reproduce the behavior:

  1. Download and open this Gaphor project: monopoly.zip
  2. Open State machine "Case terrain"
  3. Look at the transition between Vide and Hypothéqué

Expected behavior

I expect the transition name to not overlap, which here should be OK given the available space around.

Screenshots

image

OS

  • Linux (Fedora 39)
  • macOS
  • Windows

Version

Version of Gaphor: 2.22.1 (Flatpak)

@amolenaar
Copy link
Member

Hi @ebousse,

The placement algorithm is pretty simple. With this angle it assumes the arrow is attached to the left side.

We have a way to find out which side a relation is connected to, so we can probably make it a little smarter. (we did not have that when the original algorithm was written)

@amolenaar amolenaar added the feature A new feature label Dec 5, 2023
@ebousse
Copy link
Author

ebousse commented Dec 6, 2023

The placement algorithm is pretty simple. With this angle it assumes the arrow is attached to the left side.

This explains a lot! Thanks, as a workaround I'll keep this fact in mind when placing my arrows.

We have a way to find out which side a relation is connected to, so we can probably make it a little smarter. (we did not have that when the original algorithm was written)

Sounds great, looking forward to it :)

@marek-piirikivi
Copy link
Contributor

That's rough problem to solve automatically. I remember @sz332 proposed somewhere to make the names draggable so you can reposition them more freely. Maybe we want to pursue this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature
Projects
None yet
Development

No branches or pull requests

3 participants