Meteor: 3.0.0-rc1 Package: allow-deny -> client side collection insert/update/remove not working as expected

[acemtp]

When executing the following line on the client with meteor 3, it should work since minimongo doesn't require async function calls.

Meteor.users.update(Meteor.userId(), { $set: { 'profile.ok': 1 }})

It generates this error on the server:

 Exception while invoking method '/users/update' Error: findOne +  is not available on the server. Please use findOneAsync() instead.
     at Object.ret.<computed> (packages/mongo/remote_collection_driver.js:52:15)
     at Object.<anonymous> (packages/matb33:collection-hooks/findone.js:27:22)
     at Object.collection.<computed> [as findOne] (packages/matb33:collection-hooks/collection-hooks.js:116:21)
     at CollectionPrototype._validatedUpdate (packages/allow-deny/allow-deny.js:485:32)
     at MethodInvocation.m.<computed> (packages/allow-deny/allow-deny.js:193:46)

The reason is that in allow-deny.js of the AllowDeny package, the old method _validatedUpdate() is called but contains a findOne that is not Async.

Current Fix:

On our server code, we added this lines to override the deprecated function

if (Meteor.isServer) {
  Mongo.Collection.prototype._validatedInsert = Mongo.Collection.prototype._validatedInsertAsync;
  Mongo.Collection.prototype._validatedUpdate = Mongo.Collection.prototype._validatedUpdateAsync;
  Mongo.Collection.prototype._validatedRemove = Mongo.Collection.prototype._validatedRemoveAsync;
}

Solution 1:

Update the code of _validatedInsert _validatedUpdate _validatedRemove in allow-deny.js to handle async methods

Solution 2 (better):

remove _validatedInsert _validatedUpdate _validatedRemove function and always use _validatedInsertAsync _validatedUpdateAsync _validatedRemoveAsync in both case update and updateAsync.

[nachocodoner]

Thank you for the report.

It's surprising we have not run into this issue in our automated test coverage, but we'll make sure to add it and include the fix in our nexts RCs.

[denihs]

Yes, it is strange... Anyways, let's fix it!