Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep the last sound alert in memory #109

Open
silomia opened this issue Jan 20, 2021 · 3 comments
Open

Keep the last sound alert in memory #109

silomia opened this issue Jan 20, 2021 · 3 comments

Comments

@silomia
Copy link

silomia commented Jan 20, 2021

With the new version 1.6, we can choose different sound alerts. However, when we open a new timer, the sound alert number one is selected by default. I would like Timer to keep my last choice for the next time.
In addition, for those who don't want any sound, this is also a good way (see request #19 ).

@karbassi
Copy link
Collaborator

Something to consider.

PRs welcome. Maybe @simongroenewolt, who implemented #107 ?

@robinstewart
Copy link
Contributor

BTW @simongroenewolt if you're up for working on this, it's just a few lines of code — when the user changes the sound, you set that sound number to a key in UserDefaults; then when a new timer is created, you read it back out from UserDefaults instead of always choosing the first sound. (The UserDefaults framework does all the hard work of persisting to disk between sessions etc.)

@karbassi
Copy link
Collaborator

@robinstewart Submit a PR! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants