Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from SMP to TorchSeg #1967

Open
adamjstewart opened this issue Mar 28, 2024 · 1 comment
Open

Switch from SMP to TorchSeg #1967

adamjstewart opened this issue Mar 28, 2024 · 1 comment
Assignees
Labels
dependencies Packaging and dependencies
Milestone

Comments

@adamjstewart
Copy link
Collaborator

Summary

We should consider switching from SMP to TorchSeg for our segmentation models.

Rationale

SMP is no longer maintained. TorchSeg is a fork providing important features we need:

  • Support for modern versions of timm
  • Support for ViT backends
  • Fewer dependencies
  • Better CI

Implementation

Should be a simple s/segmentation_models_pytorch/torchseg/g.

However, there are a few more things I would like to see in TorchSeg before committing to the switch:

  • Dependabot used to manage all dependencies, especially timm
  • Minimum version testing, especially timm

These are things I can set up myself when I have time (hopefully soon!)

Alternatives

I have not yet found a better alternative to SMP.

If SMP becomes maintained once again, we could contribute back all of the improvements in TorchSeg. But I find this unlikely, and I like the control we have over TorchSeg if we need to quickly add new features.

Additional information

@isaaccorley I'm opening this issue to make sure I don't forget to do this before the 0.6 release sometime in April.

@adamjstewart adamjstewart added the dependencies Packaging and dependencies label Mar 28, 2024
@adamjstewart adamjstewart added this to the 0.6.0 milestone Mar 28, 2024
@adamjstewart adamjstewart self-assigned this Mar 28, 2024
@isaaccorley
Copy link
Collaborator

I can work on figuring out why dependabot and codecov wasn't working. I'll also try running some tests with different version of timm to see what happens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Packaging and dependencies
Projects
None yet
Development

No branches or pull requests

2 participants