Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

selectableRows breaks behaviour of rowSelection formatter #4498

Open
BernhardBaumrock opened this issue May 14, 2024 · 1 comment
Open

selectableRows breaks behaviour of rowSelection formatter #4498

BernhardBaumrock opened this issue May 14, 2024 · 1 comment
Labels
Possible Bug A possible bug that needs investigation

Comments

@BernhardBaumrock
Copy link

Describe the bug

When combining the rowSelection formatter with selectableRows the UI is really un-intuitive and works exactly opposite as when rowSelection is disabled.

Tabulator Info
6.2

Working Example
https://jsfiddle.net/baumrock/y7f8ok4t/24/

To Reproduce

  • In the first table select rows 1-4 by using shift-click
  • Then try to unselect row 2 by clicking on the checkbox

I would expect: Row 2 unselected, row 1,3,4 stay selected. Instead it selects only row 2 and deselects all others.

I know I can use CMD to flip the behaviour of the click, but that's only intuitive (and correct) on the row selection, but not when clicking on the tickbox.

Expected behavior
Clicks on tickbox should always work the same, no matter if row selection is enabled or not. A click on a checked checkbox should uncheck it. A click on an unchecked checkbox should check it.

I think the rowheaders should be excluded from toggling selection. Maybe at all, maybe only if the tickbox formatter is used.

Screenshots
Recording 2024-05-14 at 23 44 32

Desktop (please complete the following information):

  • OS: Mac
  • Browser Chrome

Thx!

@BernhardBaumrock BernhardBaumrock added the Possible Bug A possible bug that needs investigation label May 14, 2024
@BernhardBaumrock BernhardBaumrock changed the title selectableRows breaks rowSelection formatter selectableRows breaks behaviour of rowSelection formatter May 14, 2024
@BernhardBaumrock
Copy link
Author

PS: In the second table of the fiddle do the same:

  • select rows 1-4
  • click on the checkbox of row 2

--> row2 is deselected, row 1,3,4 stay selected. That's how it should always be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Possible Bug A possible bug that needs investigation
Projects
None yet
Development

No branches or pull requests

1 participant