Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust selection of all pages via Shift + click #489

Open
angsch opened this issue May 15, 2021 · 3 comments
Open

Adjust selection of all pages via Shift + click #489

angsch opened this issue May 15, 2021 · 3 comments
Labels
bug PRs welcome The person setting this label (or assigned to this Issue) is happy to give guidance UX UI/UX (User Interface / User Experience)

Comments

@angsch
Copy link
Member

angsch commented May 15, 2021

Describe the bug

Pages can be selected by (1) clicking on an iconview thumbnail and (2) selections offered in the hamburger menu/shortcuts. Mixing these two ways can yield an unexpected selection.

To Reproduce

  1. Load a document with at least 2 pages.
  2. Select all pages via Ctrl + A.
  3. Hold shift and click on the first page.

Expected behavior

The selection should comprise only the first page. This is the behavior reached with

  1. Select all pages by clicking on the first page, holding shift, and clicking on the last page.

The problem affects Invert Selection, too.

@dreua dreua added bug PRs welcome The person setting this label (or assigned to this Issue) is happy to give guidance UX UI/UX (User Interface / User Experience) labels May 15, 2021
@Bugswriter
Copy link

I tried, everything seems fine to me. Is this bug fixed?

@kbengs
Copy link
Member

kbengs commented Apr 10, 2023

I am not sure but I think it works fine too. Shall we close this or do someone disagree?

@dreua
Copy link
Member

dreua commented Apr 12, 2023

Actual behavior

The selection does not change, all pages are still selected.

It's not a big deal but if we can get a little closer to the standard behavior (e.g. in Nautilus) that always a plus. Btw: If you shift+click the second or any other page the selection should span from the first till the page you clicked. (You'll need at least 3 pages to test that.)

I tested the current main on Fedora 37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug PRs welcome The person setting this label (or assigned to this Issue) is happy to give guidance UX UI/UX (User Interface / User Experience)
Projects
None yet
Development

No branches or pull requests

4 participants