Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URLBar suggestions is broken with 126 #771

Closed
zapSNH opened this issue Apr 6, 2024 · 4 comments · Fixed by #782
Closed

URLBar suggestions is broken with 126 #771

zapSNH opened this issue Apr 6, 2024 · 4 comments · Fixed by #782
Labels
bug Something isn't working

Comments

@zapSNH
Copy link
Contributor

zapSNH commented Apr 6, 2024

Describe the bug
The .urlbarView is covering the URLBar content. If I remove this line, then the problem goes away.

To Reproduce

  1. Have Firefox 126
  2. Click on the URLBar
  3. Error appears

Expected behavior
The URLBar isn't covered by .urlbarView.

Screenshots
screenshot

Setup information

  • OS: Fedora
  • Installation method: tarball (Firefox), git (theme)
  • Firefox version: 126 (2024-04-05)
  • Theme version: master
  • Optional features enabled: none

Additional context
Simply pushing .urlbarView down isn't enough since the text content of the URLBar doesn't show up.

@zzzsyyy
Copy link

zzzsyyy commented May 16, 2024

It may be necessary to port this fix to the beta branch, as many people use the beta branch on firefox-beta

@paulvt
Copy link

paulvt commented May 18, 2024

I still have this issue with the v126 tag checked out on Firefox 126.0.

And it is the same whether the --urlbar-container-height is 0px, 34px (as it is now) or 200px.

@thomasaull
Copy link

thomasaull commented May 18, 2024

@paulvt Maybe try to check out the master. This works for me on Firefox Developer Edition which currently is on v126

@paulvt
Copy link

paulvt commented May 18, 2024

I already did, but master is only one commit ahead of v126 and that is a README.md change (see 1efffca).

@rafaelmardojai rafaelmardojai unpinned this issue May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants