Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vertical tab - Extension] Visual bug, Inconsistency #781

Closed
ataractic opened this issue Apr 28, 2024 · 3 comments · Fixed by #796
Closed

[Vertical tab - Extension] Visual bug, Inconsistency #781

ataractic opened this issue Apr 28, 2024 · 3 comments · Fixed by #796
Labels
bug Something isn't working

Comments

@ataractic
Copy link

Describe the bug
When using light theme on white-background websites, we can't see the edge of the vertical tab bar, which makes it really unaesthetically pleasing (see the screenshots).

To Reproduce

  1. Install firefox-gnome-theme using curl script
  2. Install Tab Center Reborn and copy its' firefox-gnome-theme styling from the repository
  3. Go on GitHub, or any light background website
  4. See the thing

Expected behavior
A 1px-wide separator should be present on the vertical tab bar edge to maintain visual consistency

Screenshots
Firefox New Tab
GitHub example

Setup information

  • OS: Fedora 40
  • Installation method: Curl script without sudo
  • Firefox version: 125
  • Theme version: v125 / master branch for vertical tabs styling
  • Optional features enabled: gnomeTheme.extensions.tabCenterReborn, gnomeTheme.hideSingleTab, gnomeTheme.hideWebrtcIndicator

Additional context
Tested with and without gnomeTheme.extensions.tabCenterReborn.alwaysOpen and gnomeTheme.extensions.tabCenterReborn.animationDisabled

@ataractic ataractic added the bug Something isn't working label Apr 28, 2024
@ataractic ataractic changed the title [Vertical tab - Extension] [Vertical tab - Extension] Visual bug, Inconsistency Apr 28, 2024
@BirdInFire
Copy link
Contributor

BirdInFire commented May 26, 2024

It's indeed an issue, I will check on this very soon :)

edit: I also will try the mod on light theme from here (since I dev on dark I never checked on light)

BirdInFire added a commit to BirdInFire/firefox-gnome-theme that referenced this issue May 26, 2024
As reported in this feedback no separator where showed on the sidebar.

rafaelmardojai#781
@BirdInFire
Copy link
Contributor

@ataractic have made a PR to fix, in the meantime you can add this into : theme/extensions/tab-center-reborn.css and restart,

Note : I have copied the way the browser draw the line under the header bar, so I will not change the color or the size / transparency (because by coping this code it will change too if Mozilla (or this theme) decide to modify the color in the variable).

#sidebar-box{
        border-right: 0.01px solid var(--chrome-content-separator-color) !important;
}

@rafaelmardojai rafaelmardojai linked a pull request May 27, 2024 that will close this issue
rafaelmardojai pushed a commit that referenced this issue May 27, 2024
As reported in this feedback no separator where showed on the sidebar.

#781
@ataractic
Copy link
Author

Thank you @BirdInFire

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants