Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to skip Yoloact inst-seg tests for the parallel GPU inference server #384

Closed
1 of 2 tasks
bigbitbus opened this issue May 10, 2024 · 3 comments · Fixed by #379
Closed
1 of 2 tasks

Need to skip Yoloact inst-seg tests for the parallel GPU inference server #384

bigbitbus opened this issue May 10, 2024 · 3 comments · Fixed by #379
Labels
bug Something isn't working

Comments

@bigbitbus
Copy link
Contributor

bigbitbus commented May 10, 2024

Search before asking

  • I have searched the Inference issues and found no similar bug report.

Bug

When running the tests on Nvidia T4 via GH actions, such errors are encountered: https://github.com/roboflow/inference/actions/runs/8992522142

This is because the parallel GPU inference docker does not support Yoloact Inst Seg.

This code fixes the issue by skipping yoloact tests:

if test["description"] == "YOLACT Instance Segmentation" and is_parallel_server:

if test["description"] == "YOLACT Instance Segmentation" and is_parallel_server:

After this, the GH action passes (example link below):
https://github.com/roboflow/inference/actions/runs/9023206470

PR to make the test change: #379

Environment

Nvidia GPU container

Minimal Reproducible Example

https://github.com/roboflow/inference/actions/runs/8992522142

Additional

No response

Are you willing to submit a PR?

Yes, already submitted #379

  • Yes I'd like to help by submitting a PR!
@bigbitbus bigbitbus added the bug Something isn't working label May 10, 2024
@bigbitbus
Copy link
Contributor Author

@PawelPeczek-Roboflow fixing the GPU test

@PawelPeczek-Roboflow
Copy link
Collaborator

👍

@grzegorz-roboflow grzegorz-roboflow linked a pull request May 22, 2024 that will close this issue
4 tasks
@grzegorz-roboflow
Copy link
Contributor

Closing as this change was already added within #379

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants