Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: plain ASCII support #586

Open
SPYFF opened this issue Feb 20, 2024 · 4 comments
Open

Feature: plain ASCII support #586

SPYFF opened this issue Feb 20, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@SPYFF
Copy link

SPYFF commented Feb 20, 2024

Hello!

Great tool, very useful for my notes. However I would like to use it for internet draft illustration (https://www.ietf.org/standards/rfcs/, for example: https://www.rfc-editor.org/rfc/rfc9526.txt) which sadly only a plain ASCII thing. It would be possible to support plain ASCII (without Unicode characters)? Yes, that renderes poorly however it would be still huge help for me (and for the internet engineering community).

@tuanchauict
Copy link
Owner

Sorry for the late response.
Actually, this request is one of my plans because sometimes, I also prefer simple characters like -+| rather than characters like ┐┌.

Luckily, this is not hard, we can add a new stroke style (see PredefinedStraightStrokeStyle).

We can also add a mask to replace the stroke characters with the equivalent ones when doing export.

However, I'm busy with porting the Kotlin code into TypeScript recently (#584) (it sounds crazy but for the future of MonoSketch and also for me to learn new stuffs - MonoSketch is purely a place for practicing engineering).

Sorry for making you keep waiting longer but this request will definitely be implemented.

@tuanchauict tuanchauict added the enhancement New feature or request label Feb 23, 2024
@SPYFF
Copy link
Author

SPYFF commented Feb 23, 2024

Thank you for the detailed response.

No need to hurry, I will be happy when its done. I just recently found this tool and I'm very happy with it as is for illustrating personal notes. Sometimes my colleagues and I need to illustrate internet drafts (every 3-6 months or so) and the ASCII mode would help with that.

A question about the typescript code. Will the whole project be converted to Typescript or just a part of it? From the output it looks like you are rewriting it from scratch. Anyway, keep up the good work and have fun learning!

@tuanchauict
Copy link
Owner

I didn't want to, but, unfortunately, I'm porting from scratch.
The number of codes of MonoSketch is not big (~19k), so, this is not a heavy task so far. Only some parts are more complicated than others, and most of the code is quite straightforward.

@SPYFF
Copy link
Author

SPYFF commented Feb 23, 2024

I see. Hopefully on the long run it might attract more contributors, I assume TS is more popular than Kotlin these days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants