battery: remove inotify since it doesn't serve much purpose #2704
+10
−100
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue: #2662
This pull request removes inotify integration for the battery module because inotify can't observe changes to the /sys filesystem when made from the kernel-side. This leads to behaviour where the widget only updates on interval or when something else accesses one of the files (eg.
cat /sys/class/power_supply/BAT0/uevent
). Now this also means that removing/adding new batteries isn't handled properly.So maybe the actual solution is to copy whatever upower does or just deprecate the battery module?