[ENHANCEMENT] Character Pixel Icon Data Accessible via Character Metadata #2465
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Freeplay and the chart editor now read from character metadata instead of hard-coding assigned character pixel icons. Existing character metadata files have updated with respective icons previously assigned in the source code . Additionally, the ability to flip the icons horizontally and adjusting the origin offset is now included via the metadata.
No issues found after testing.
Situation:
For the modders who have multiple versions of some character and would like to use the same character icon, it was previously not possible simply due to the fact that prior to this change, the pixel icon is determined by the character's id name rather than a specified pixel ID. In this case, I have a characters labeled as "hugenate-opponent" and "hugenate-playable". I also have an icon file named "hugenate", and I want both of these characters to use the same icon. However, neither will work since they would have to be the same name as the freeplay icon file.
Now with this change, it corrects the issue and allows for me to individually assign the icon id to the players in their metadata. NOTE: If the id is left as null, the game will automatically set it to the same name as their character id.
After modifying it with this data, this is the new result!
New parameters such as flipX and origin are also included to adjust icons if they overlap the text:
Before:
After: