Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] Character Pixel Icon Data Accessible via Character Metadata #2465

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

MadBear422
Copy link
Contributor

@MadBear422 MadBear422 commented May 11, 2024

Freeplay and the chart editor now read from character metadata instead of hard-coding assigned character pixel icons. Existing character metadata files have updated with respective icons previously assigned in the source code . Additionally, the ability to flip the icons horizontally and adjusting the origin offset is now included via the metadata.
No issues found after testing.

Situation:
For the modders who have multiple versions of some character and would like to use the same character icon, it was previously not possible simply due to the fact that prior to this change, the pixel icon is determined by the character's id name rather than a specified pixel ID. In this case, I have a characters labeled as "hugenate-opponent" and "hugenate-playable". I also have an icon file named "hugenate", and I want both of these characters to use the same icon. However, neither will work since they would have to be the same name as the freeplay icon file.
image
Now with this change, it corrects the issue and allows for me to individually assign the icon id to the players in their metadata. NOTE: If the id is left as null, the game will automatically set it to the same name as their character id.
image
After modifying it with this data, this is the new result!
image
New parameters such as flipX and origin are also included to adjust icons if they overlap the text:
image
Before:
image
After:
image

Pixel icon data is now accessed through character metadata and is no longer hard-coded to assign specific icons to specific characters
@MadBear422 MadBear422 changed the title Character Pixel Icon Data Accessed via Character Metadata Character Pixel Icon Data Accessible via Character Metadata May 11, 2024
@MadBear422 MadBear422 changed the title Character Pixel Icon Data Accessible via Character Metadata [ENHANCEMENT] Character Pixel Icon Data Accessible via Character Metadata May 14, 2024
@tposejank
Copy link

pretty cool, should be looked into

@EliteMasterEric
Copy link
Member

At an initial glance, this looks great and I wouldn't have implemented this differently (save maybe naming it freeplayIcon but that's too much of a nitpick and I think it's fair to just leave it as is).

Do definitely want to do more review first though.

@EliteMasterEric EliteMasterEric added the enhancement New feature or request label May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants