Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hold notes on downscroll #2488

Merged
merged 3 commits into from
May 29, 2024
Merged

Conversation

MaybeMaru
Copy link

Fixes the position of hold notes on downscroll to be on the correct center of the note and strum

Before After
before after

@gamerbross
Copy link
Contributor

i thought this was intended, but please move this to be consistent 🙏 🙏
image

@MaybeMaru
Copy link
Author

sure one sec

@amyspark-ng
Copy link

wasn't this fixed in 0.3.3?

@MaybeMaru
Copy link
Author

wasn't this fixed in 0.3.3?

It fixed the sustains flickering problem, not this

@ninjamuffin99 ninjamuffin99 added this to the 0.4.0 milestone May 24, 2024
@ninjamuffin99 ninjamuffin99 self-requested a review May 24, 2024 20:19
@EliteMasterEric EliteMasterEric self-assigned this May 29, 2024
@EliteMasterEric
Copy link
Member

nice pfp

@EliteMasterEric EliteMasterEric merged commit 34ca8dc into FunkinCrew:develop May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants