Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: LEAP-1119: Feature/gridview thumbnail #5769

Merged
merged 12 commits into from
Jun 7, 2024

Conversation

FrsECM
Copy link
Contributor

@FrsECM FrsECM commented Apr 23, 2024

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

  • Product design
  • Backend (Database)
  • Backend (API)
  • Frontend

Describe the reason for change

When using multilayered images, the original behaviour was to create a src that separate each image by a ','.

This way, it's not displayable.
image

What does this fix?

It fixes an issue in the gridview when there is multiple layers image.
image
It's even possible to use a specific "thumbnail" field, that allows to add a specific thumbnail to be use.
image
If you want the thumbnail to be displayed in the column view, just declare it as an image in the taxonomy :
image
image

What is the new behavior?

There is two different new behaviors.
If a "thumbnail" is provided :

  • The gridview uses the thumbnail field.
    The advantage is the ability to use a thumbnail that has a lower resolution than the original image.
    else:
    We use the first image of the multilayer images.

What is the current behavior?

The current behavior is that in this case, images url are separated by a ',' in the image src.
What display nothing at all

Does this change affect performance?

It can improve the performance because thumbnail can be a lower resolution image.

Does this PR introduce a breaking change?

(check only one)

  • Yes, and covered entirely by feature flag(s)
  • Yes, and covered partially by feature flag(s)
  • No
  • Not sure (briefly explain the situation below)

What level of testing was included in the change?

(check all that apply)

  • e2e
  • integration
  • unit

Which logical domain(s) does this change affect?

GridView => Data Exploration

Copy link

netlify bot commented Apr 23, 2024

👷 Deploy request for label-studio-docs-new-theme pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit c033950

Copy link

netlify bot commented Apr 23, 2024

👷 Deploy request for heartex-docs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit c033950

@github-actions github-actions bot added the feat label Apr 23, 2024
@FrsECM FrsECM marked this pull request as ready for review April 23, 2024 07:46
@sajarin
Copy link
Contributor

sajarin commented May 29, 2024

/jira create

Workflow run
Jira issue TRIAG-577 is created

@juliosgarbi juliosgarbi changed the title feat: Feature/gridview thumbnail feat: LEAP-1119: Feature/gridview thumbnail Jun 4, 2024
@sajarin sajarin added Community Community Feature Requests, Open Issues, Bugs Reported, or Comments community:fix labels Jun 5, 2024
Copy link
Contributor

@juliosgarbi juliosgarbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added to the PR unit tests, also I removed the feature about show thumbnails, we already have something similar to it on the list view that doesn't need add any tags on the config, you just need to add a new node on the data (e.g. thumb), enable this column on the columns dropdown, and change the view mode from str to img on the thumb column, overall it looks good, thanks for the contribution!

@FrsECM
Copy link
Contributor Author

FrsECM commented Jun 6, 2024

I added to the PR unit tests, also I removed the feature about show thumbnails, we already have something similar to it on the list view that doesn't need add any tags on the config, you just need to add a new node on the data (e.g. thumb), enable this column on the columns dropdown, and change the view mode from str to img on the thumb column, overall it looks good, thanks for the contribution!

If you have a piece of document about that I'm very interessed. It can help when we have very high resolution images.

Thanks !

@juliosgarbi juliosgarbi merged commit 3f59a5a into HumanSignal:develop Jun 7, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community:fix Community Community Feature Requests, Open Issues, Bugs Reported, or Comments feat
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants