Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: jsonL support #5830

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

feat: jsonL support #5830

wants to merge 2 commits into from

Conversation

Jorjeous
Copy link

@Jorjeous Jorjeous commented May 6, 2024

PR fulfills these requirements

  • [+] Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • [-] Tests for the changes have been added/updated (for bug fixes/features)
  • [-] Docs have been added/updated (for bug fixes/features)
  • [-] Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • [+] Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Backend (Database)
  • Backend (API)
  • Frontend
  • [+] OtherBackend

Describe the reason for change

(link to issue, supportive screenshots etc.)
People often confuse json and jsonL
The nemo framework deliberately uses the name json, although in fact it is jsonL

What does this fix?

(if this is a bug fix)

What is the new behavior?

(if this is a breaking or feature change)
Ability to import jsonL

What is the current behavior?

(if this is a breaking or feature change)

What libraries were added/updated?

(list all with version changes)
No

Does this change affect performance?

(if so describe the impacts positive or negative)
No

Does this change affect security?

(if so describe the impacts positive or negative)
No

What alternative approaches were there?

(briefly list any if applicable)

What feature flags were used to cover this change?

(briefly list any if applicable)

Does this PR introduce a breaking change?

(check only one)

  • Yes, and covered entirely by feature flag(s)
  • Yes, and covered partially by feature flag(s)
  • [+] No
  • Not sure (briefly explain the situation below)

What level of testing was included in the change?

(check all that apply)

  • e2e
  • integration
  • unit
  • [+] Manual

Which logical domain(s) does this change affect?

(for bug fixes/features, be as precise as possible. ex. Authentication, Annotation History, Review Stream etc.)
Data import

Signed-off-by: George <gzelenfroind@nvidia.com>
Copy link

netlify bot commented May 6, 2024

👷 Deploy request for label-studio-docs-new-theme pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit e41bb8e

Copy link

netlify bot commented May 6, 2024

👷 Deploy request for heartex-docs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit e41bb8e

Copy link

sentry-io bot commented May 6, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: label_studio/data_import/models.py

Function Unhandled Issue
read_tasks [**ValidationError: "Failed to parse input file upload/64275/1870f275-dic2023_traducido.csv: 'utf-8' codec can't dec...** ...
Event Count: 1

Did you find this useful? React with a 👍 or 👎

@github-actions github-actions bot added the feat label May 6, 2024
@Jorjeous Jorjeous changed the title feat: jsonL suppo feat: jsonL support May 6, 2024
@sajarin
Copy link
Contributor

sajarin commented May 8, 2024

/jira create

Workflow run
Jira issue TRIAG-550 is created

…trat as jsonL

Signed-off-by: George <gzelenfroind@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants