Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove cursor from crosshair and restore cursors when deleting an annotation #5878

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

NickSwardh
Copy link

PR fulfills these requirements

  • [x ] Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • [x ] Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • [ x] Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Backend (Database)
  • Backend (API)
  • [x ] Frontend

Describe the reason for change

(link to issue, supportive screenshots etc.)

What does this fix?

Hides visible cursor from crosshair, providing the user a clear view with only the crosshair guidlines visible. Also restores the cursor to default after the user have deleted an annotation while hovering and pressing "backspace" causing the cursor to be stuck on "pointer".

What is the new behavior?

A clear crosshair without a cursors on top and restored cursors after the user have deleted an annotation.

What is the current behavior?

(if this is a breaking or feature change)

What libraries were added/updated?

(list all with version changes)

Does this change affect performance?

(if so describe the impacts positive or negative)

Does this change affect security?

(if so describe the impacts positive or negative)

What alternative approaches were there?

(briefly list any if applicable)

What feature flags were used to cover this change?

(briefly list any if applicable)

Does this PR introduce a breaking change?

(check only one)

  • Yes, and covered entirely by feature flag(s)
  • Yes, and covered partially by feature flag(s)
  • [ x] No
  • Not sure (briefly explain the situation below)

What level of testing was included in the change?

(check all that apply)

  • [x ] e2e
  • integration
  • unit

Which logical domain(s) does this change affect?

(for bug fixes/features, be as precise as possible. ex. Authentication, Annotation History, Review Stream etc.)

Copy link

netlify bot commented May 13, 2024

👷 Deploy request for label-studio-docs-new-theme pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 0ee538d

Copy link

netlify bot commented May 13, 2024

👷 Deploy request for heartex-docs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 0ee538d

@hlomzik
Copy link
Collaborator

hlomzik commented May 14, 2024

/jira create

Workflow run
Jira issue TRIAG-553 is created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants