Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Incorrect output for A or B with dim=1 in GEMM #4890

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

w8501
Copy link
Contributor

@w8501 w8501 commented Jul 28, 2023

Fixed a bug in the GEMM layer where incorrect shapes of M, N, and K occurred when matrix A or matrix B had dim=1, leading to incorrect output results

@codecov-commenter
Copy link

codecov-commenter commented Jul 28, 2023

Codecov Report

Merging #4890 (b67eefc) into master (c45c01c) will increase coverage by 5.09%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           master    #4890       +/-   ##
===========================================
+ Coverage   89.81%   94.91%    +5.09%     
===========================================
  Files         306      776      +470     
  Lines       86875   226096   +139221     
===========================================
+ Hits        78024   214589   +136565     
- Misses       8851    11507     +2656     
Files Changed Coverage Δ
src/layer/arm/gemm_arm.cpp 99.56% <100.00%> (ø)
src/layer/arm/gemm_arm_asimdhp.cpp 99.57% <100.00%> (ø)
src/layer/arm/gemm_arm_vfpv4.cpp 98.58% <100.00%> (ø)
src/layer/vulkan/gemm_vulkan.cpp 98.05% <100.00%> (ø)
src/layer/x86/gemm_x86.cpp 99.83% <100.00%> (+1.10%) ⬆️

... and 645 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants