COM Ports not found hard crash fix #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed an issue with loading com ports on start up, where it attempted to set combo box selectedindex to 0 where no ports found.
Fixed additional port search where it will not change anything if no ports found.
Added message on COM port refresh in case nothing found to alert user of a problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to debug, I encountered an issue with hard-crash coming from the Form1_Load method, result was that
string[] ports = SerialPort.GetPortNames();returned no ports (my PC has no COM). I fixed it by checking for the ports array to be longer than 0 before assigning anything thus preventing a hard crash.Also added a message when user manually refreshes COM ports that will show in case no ports were found further preventing hard crash of the program.