Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: build system refactoring draft #1312

Draft
wants to merge 1 commit into
base: v6
Choose a base branch
from
Draft

wip: build system refactoring draft #1312

wants to merge 1 commit into from

Conversation

friday
Copy link
Member

@friday friday commented Nov 19, 2023

Import version and gi_versions from pyproject.toml

Was part of the PR for #1311 but I decided to go a different route because this is not worth it (at least not yet). I mostly wanted to keep this for future reference.

I'm note sure the way the tomli version is specified is correct and works for building the deb package (Seems not for the deb, but looks correct according to the "platform specific dependencies" docs).

_project_root = Path(__file__).parent.parent also doesn't work on Nix

importlib.metadata.version("ulauncher") is NOT an alternative. I tested it it had some nasty side effects and limitations:

  1. On our Ubuntu Docker image I needed the sys.path.insert(0, str(PROJECT_ROOT)) hack or it would throw importlib.metadata.PackageNotFoundError. This was not needed on my Arch Linux desktop with Python 3.11.
  2. It only works with the version and maybe secription (not custom data like the gi versions)
  3. It shortens the version from example 1.2.3-beta4 to 1.2.3-b4 (this will break our deb builds).
  4. Somehow it also got the wrong version when I tested (tested on 6.0.0-beta6 but it showed 6.0.0b4 even though I didn't have any version installed)

@friday friday marked this pull request as draft November 19, 2023 16:02
@friday friday changed the title build: wip build system refactoring draft wip: build system refactoring draft Nov 19, 2023
@friday friday force-pushed the wip/1311 branch 3 times, most recently from 26b3164 to 1cdaeb4 Compare November 19, 2023 22:23
@friday friday force-pushed the wip/1311 branch 2 times, most recently from 9418f4e to 8de4c9f Compare March 29, 2024 21:30
…we preferably don't want to do this as we just got rid of that build step in #1313)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant