Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding erc7677 support on laboratory #2271

Merged
merged 31 commits into from
May 22, 2024
Merged

feat: adding erc7677 support on laboratory #2271

merged 31 commits into from
May 22, 2024

Conversation

KannuSingh
Copy link
Collaborator

No description provided.

Copy link

vercel bot commented May 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
web3modal-gallery ✅ Ready (Inspect) Visit Preview May 21, 2024 10:31pm
web3modal-laboratory ✅ Ready (Inspect) Visit Preview May 21, 2024 10:31pm

Copy link
Member

@arein arein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add some automated tests?

@arein arein requested a review from devceline May 17, 2024 20:03
Copy link
Contributor

@tomiir tomiir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments related to code style mainly. let me know what u think!
else looks good 💪

Copy link
Contributor

@tomiir tomiir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@KannuSingh KannuSingh merged commit 829a1ee into V4 May 22, 2024
9 checks passed
@KannuSingh KannuSingh deleted the add-erc7677-support branch May 22, 2024 13:28
@tomiir tomiir mentioned this pull request May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants