-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UIProcess] Unsafe downcast in ScrollingTreeStickyNode::computeLayerPosition leading to type confusion. #28663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonWBedard
added
the
Scrolling
Bugs related to main thread and off-main thread scrolling
label
May 16, 2024
EWS run on previous version of this PR (hash cc0243e) |
webkit-ews-buildbot
added
the
merging-blocked
Applied to prevent a change from being merged
label
May 16, 2024
JonWBedard
removed
the
merging-blocked
Applied to prevent a change from being merged
label
May 16, 2024
EWS run on previous version of this PR (hash af16092) |
webkit-ews-buildbot
added
the
merging-blocked
Applied to prevent a change from being merged
label
May 16, 2024
JonWBedard
removed
the
merging-blocked
Applied to prevent a change from being merged
label
May 16, 2024
webkit-ews-buildbot
added
the
merging-blocked
Applied to prevent a change from being merged
label
May 16, 2024
EWS run on previous version of this PR (hash f762cb4) |
JonWBedard
removed
the
merging-blocked
Applied to prevent a change from being merged
label
May 16, 2024
EWS run on current version of this PR (hash 9e21554) |
robert-jenner
added
the
safe-merge-queue
Applied to automatically send a pull-request to merge-queue after passing EWS checks
label
May 17, 2024
JonWBedard
added
merge-queue
Applied to send a pull request to merge-queue
and removed
safe-merge-queue
Applied to automatically send a pull-request to merge-queue after passing EWS checks
merge-queue
Applied to send a pull request to merge-queue
labels
May 17, 2024
β¦osition leading to type confusion. https://bugs.webkit.org/show_bug.cgi?id=271395 rdar://125084284 Reviewed by Chris Dumez. Fix various places in scrolling tree-related code where we do unchecked `downcast<>`s of scrolling tree types. * Source/WebCore/page/scrolling/AsyncScrollingCoordinator.cpp: (WebCore::AsyncScrollingCoordinator::frameViewVisualViewportChanged): (WebCore::AsyncScrollingCoordinator::setViewportConstraintedNodeConstraints): * Source/WebCore/page/scrolling/ScrollingStateOverflowScrollProxyNode.cpp: (WebCore::ScrollingStateOverflowScrollProxyNode::dumpProperties const): * Source/WebCore/page/scrolling/ScrollingStateStickyNode.cpp: (WebCore::ScrollingStateStickyNode::computeLayerPosition const): * Source/WebCore/page/scrolling/ScrollingTreeOverflowScrollProxyNode.cpp: (WebCore::ScrollingTreeOverflowScrollProxyNode::dumpProperties const): * Source/WebCore/page/scrolling/ScrollingTreeStickyNode.cpp: (WebCore::ScrollingTreeStickyNode::computeLayerPosition const): Originally-landed-as: 272448.773@safari-7618-branch (052845b). rdar://128088754 Canonical link: https://commits.webkit.org/278914@main
webkit-commit-queue
force-pushed
the
eng/128088754
branch
from
May 17, 2024 17:11
9e21554
to
f2967e8
Compare
Committed 278914@main (f2967e8): https://commits.webkit.org/278914@main Reviewed commits have been landed. Closing PR #28663 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Applied to send a pull request to merge-queue
label
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
f2967e8
9e21554