Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WebGPU] RGBA16Float canvas context isn't created correctly #28666

Merged
merged 1 commit into from
May 18, 2024
Merged

[WebGPU] RGBA16Float canvas context isn't created correctly #28666

merged 1 commit into from
May 18, 2024

Conversation

mwyrzykowski
Copy link
Contributor

@mwyrzykowski mwyrzykowski commented May 16, 2024 •
edited by webkit-early-warning-system

8e0baad

[WebGPU] RGBA16Float canvas context isn't created correctly
https://bugs.webkit.org/show_bug.cgi?id=274270
radar://128064803

Reviewed by Dan Glastonbury.

Logic for creating RGBA16Float backings was wrong for the double
and triple buffer, correct and add regression test.

* LayoutTests/TestExpectations:
* LayoutTests/fast/webgpu/fuzz-274270-expected.txt: Added.
* LayoutTests/fast/webgpu/fuzz-274270.html: Added.
* Source/WebGPU/WebGPU/PresentationContextIOSurface.mm:
(WebGPU::PresentationContextIOSurface::configure):

Canonical link: https://commits.webkit.org/278955@main

153e6e5

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@mwyrzykowski mwyrzykowski self-assigned this May 16, 2024
@mwyrzykowski mwyrzykowski added the WebGPU For bugs in WebGPU label May 16, 2024
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 153e6e5)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label May 16, 2024
@mwyrzykowski mwyrzykowski removed the merging-blocked Applied to prevent a change from being merged label May 16, 2024
@mwyrzykowski mwyrzykowski requested a review from djg May 17, 2024 23:19
djg
djg approved these changes May 18, 2024
View reviewed changes
Copy link
Contributor

@djg djg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@mwyrzykowski mwyrzykowski added the merge-queue Applied to send a pull request to merge-queue label May 18, 2024
@mwyrzykowski
[WebGPU] RGBA16Float canvas context isn't created correctly
8e0baad 
https://bugs.webkit.org/show_bug.cgi?id=274270
radar://128064803

Reviewed by Dan Glastonbury.

Logic for creating RGBA16Float backings was wrong for the double
and triple buffer, correct and add regression test.

* LayoutTests/TestExpectations:
* LayoutTests/fast/webgpu/fuzz-274270-expected.txt: Added.
* LayoutTests/fast/webgpu/fuzz-274270.html: Added.
* Source/WebGPU/WebGPU/PresentationContextIOSurface.mm:
(WebGPU::PresentationContextIOSurface::configure):

Canonical link: https://commits.webkit.org/278955@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/WebGPU-RGBA16Float-canvas-context-isnt-created-correctly branch from 153e6e5 to 8e0baad Compare May 18, 2024 16:17
@webkit-commit-queue
Copy link
Collaborator

Committed 278955@main (8e0baad): https://commits.webkit.org/278955@main

Reviewed commits have been landed. Closing PR #28666 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 8e0baad into WebKit:main May 18, 2024
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djg djg djg approved these changes

@tadeuzagallo tadeuzagallo Awaiting requested review from tadeuzagallo tadeuzagallo is a code owner

Assignees

@mwyrzykowski mwyrzykowski

Labels
WebGPU For bugs in WebGPU
Projects
None yet
Milestone
No milestone
5 participants
@mwyrzykowski @webkit-early-warning-system @webkit-commit-queue @djg @webkit-ews-buildbot