[build.webkit.org] Bring up open source visionOS builders and testers #28667

robert-jenner · 2024-05-16T19:00:36Z

`b4e487b`

[build.webkit.org] Bring up open source visionOS builders and testers
https://bugs.webkit.org/show_bug.cgi?id=274272
rdar://121395049

Reviewed by Ryan Haddad.

Bring up of OpenSource visionOS builders and testers.

* Tools/CISupport/build-webkit-org/config.json:
* Tools/CISupport/build-webkit-org/factories.py:
(TestFactory.__init__):
* Tools/CISupport/build-webkit-org/factories_unittest.py:
(TestExpectedBuildSteps):
* Tools/CISupport/build-webkit-org/loadConfig.py:
(loadBuilderConfig):
* Tools/CISupport/build-webkit-org/public_html/dashboard/Scripts/Dashboard.js:
* Tools/CISupport/build-webkit-org/public_html/dashboard/Scripts/WebKitBuildbot.js:
(WebKitBuildbot):
* Tools/CISupport/build-webkit-org/public_html/dashboard/Styles/Main.css:
(table.queue-grid tr.platform.visionos-simulator-1 img.logo):
(table.queue-grid tr.platform.visionos-1 img.logo):
* Tools/CISupport/build-webkit-org/steps.py:
(CustomFlagsMixin.customBuildFlag):
(CustomFlagsMixin.appendCustomBuildFlags):
(CustomFlagsMixin.appendCustomTestingFlags):
(CompileWebKit):
(CompileWebKit.evaluateCommand):
(PrintConfiguration.run):
* Tools/CISupport/build-webkit-org/wkbuild.py:
(_should_file_trigger_build):
* Tools/CISupport/build-webkit-org/wkbuild_unittest.py:
(ShouldBuildTest):
(ShouldBuildTest.test_should_build):

Canonical link: https://commits.webkit.org/279249@main

afeb514

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	✅ 🧪 wincairo-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
✅ 🧪 services	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress	❌ 🧪 api-gtk
✅ 🛠 🧪 merge	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-05-16T19:03:10Z

EWS run on previous version of this PR (hash aa2cbda)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
~~🧪 style~~	✅ 🛠 ios	✅ 🛠 mac	~~🛠 wpe~~	~~🛠 wincairo~~
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~
~~🧪 webkitperl~~	⏳ 🧪 ios-wk2	✅ 🧪 api-mac	~~🧪 api-wpe~~
	⏳ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	⏳ 🛠 wpe-skia
	⏳ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	~~🛠 tv~~	⏳ 🧪 mac-AS-debug-wk2	⏳ 🧪 gtk-wk2
❌ 🧪 services	~~🛠 tv-sim~~	✅ 🧪 mac-wk2-stress	⏳ 🧪 api-gtk
	~~🛠 watch~~
	~~🛠 watch-sim~~

Tools/CISupport/build-webkit-org/factories.py

aj062 · 2024-05-16T19:21:34Z

Please have a look at unit-test failures in https://ews-build.webkit.org/#/builders/28/builds/51830/steps/13/logs/stdio

webkit-early-warning-system · 2024-05-16T19:25:11Z

EWS run on previous version of this PR (hash caf4907)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
~~🧪 style~~	✅ 🛠 ios	✅ 🛠 mac	~~🛠 wpe~~	~~🛠 wincairo~~
~~🧪 bindings~~	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~
~~🧪 webkitperl~~	~~🧪 ios-wk2~~	~~🧪 api-mac~~	~~🧪 api-wpe~~
	⏳ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	⏳ 🛠 wpe-skia
	⏳ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	~~🛠 tv~~	⏳ 🧪 mac-AS-debug-wk2	⏳ 🧪 gtk-wk2
❌ 🧪 services	~~🛠 tv-sim~~	✅ 🧪 mac-wk2-stress	⏳ 🧪 api-gtk
	~~🛠 watch~~
	~~🛠 watch-sim~~

webkit-early-warning-system · 2024-05-16T19:43:27Z

EWS run on previous version of this PR (hash 715011b)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
~~🧪 style~~	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	~~🛠 wincairo~~
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	⏳ 🧪 wpe-wk2
~~🧪 webkitperl~~	✅ 🧪 ios-wk2	✅ 🧪 api-mac	⏳ 🧪 api-wpe
	⏳ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	⏳ 🛠 wpe-skia
	⏳ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	~~🛠 tv~~	⏳ 🧪 mac-AS-debug-wk2	⏳ 🧪 gtk-wk2
❌ 🧪 services	~~🛠 tv-sim~~	✅ 🧪 mac-wk2-stress	⏳ 🧪 api-gtk
	~~🛠 watch~~
	~~🛠 watch-sim~~

webkit-early-warning-system · 2024-05-16T20:25:23Z

EWS run on previous version of this PR (hash 7814be8)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
~~🧪 style~~	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	~~🛠 wincairo~~
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	⏳ 🧪 wpe-wk2
~~🧪 webkitperl~~	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	⏳ 🧪 ios-wk2-wpt	~~🧪 mac-wk1~~	⏳ 🛠 wpe-skia
	⏳ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	~~🛠 tv~~	⏳ 🧪 mac-AS-debug-wk2	⏳ 🧪 gtk-wk2
✅ 🧪 services	~~🛠 tv-sim~~	✅ 🧪 mac-wk2-stress	⏳ 🧪 api-gtk
	~~🛠 watch~~
	~~🛠 watch-sim~~

webkit-early-warning-system · 2024-05-16T20:52:45Z

EWS run on previous version of this PR (hash fe5fc89)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	⏳ 🧪 wpe-wk2
~~🧪 webkitperl~~	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	~~🧪 ios-wk2-wpt~~	✅ 🧪 mac-wk1	⏳ 🛠 wpe-skia
	⏳ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 tv	⏳ 🧪 mac-AS-debug-wk2	⏳ 🧪 gtk-wk2
✅ 🧪 services	~~🛠 tv-sim~~	✅ 🧪 mac-wk2-stress	⏳ 🧪 api-gtk
	✅ 🛠 watch
	~~🛠 watch-sim~~

ryanhaddad

r=me with comment. Would be good to test this on UAT to make sure we didn't miss anything.

Tools/CISupport/build-webkit-org/factories.py

webkit-early-warning-system · 2024-05-16T22:46:36Z

EWS run on previous version of this PR (hash 3c1756a)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	✅ 🧪 wincairo-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
✅ 🧪 services	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-05-23T00:05:04Z

EWS run on previous version of this PR (hash 3938d0a)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	~~🛠 wpe~~	~~🛠 wincairo~~
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~	~~🧪 wincairo-tests~~
✅ 🧪 webkitperl	⏳ 🧪 ios-wk2	⏳ 🧪 api-mac	~~🧪 api-wpe~~
	⏳ 🧪 ios-wk2-wpt	~~🧪 mac-wk1~~	✅ 🛠 wpe-cairo
~~🛠 🧪 jsc~~	⏳ 🧪 api-ios	⏳ 🧪 mac-wk2	✅ 🛠 gtk
~~🛠 🧪 jsc-arm64~~	~~🛠 tv~~	⏳ 🧪 mac-AS-debug-wk2	⏳ 🧪 gtk-wk2
✅ 🧪 services	~~🛠 tv-sim~~	✅ 🧪 mac-wk2-stress	⏳ 🧪 api-gtk
	~~🛠 watch~~		✅ 🛠 jsc-armv7
	✅ 🛠 watch-sim		⏳ 🧪 jsc-armv7-tests

webkit-early-warning-system · 2024-05-23T01:07:23Z

EWS run on previous version of this PR (hash 32ef387)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	~~🛠 wpe~~	~~🛠 wincairo~~
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~	~~🧪 wincairo-tests~~
✅ 🧪 webkitperl	⏳ 🧪 ios-wk2	⏳ 🧪 api-mac	~~🧪 api-wpe~~
	⏳ 🧪 ios-wk2-wpt	⏳ 🧪 mac-wk1	~~🛠 wpe-cairo~~
~~🛠 🧪 jsc~~	⏳ 🧪 api-ios	⏳ 🧪 mac-wk2	✅ 🛠 gtk
~~🛠 🧪 jsc-arm64~~	~~🛠 tv~~	⏳ 🧪 mac-AS-debug-wk2	⏳ 🧪 gtk-wk2
✅ 🧪 services	~~🛠 tv-sim~~	~~🧪 mac-wk2-stress~~	⏳ 🧪 api-gtk
	~~🛠 watch~~		✅ 🛠 jsc-armv7
	~~🛠 watch-sim~~		~~🧪 jsc-armv7-tests~~

webkit-early-warning-system · 2024-05-23T01:31:15Z

EWS run on previous version of this PR (hash e5d8051)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	✅ 🧪 wincairo-tests
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	⏳ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
	⏳ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 tv	❌ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
✅ 🧪 services	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-05-23T16:36:15Z

EWS run on current version of this PR (hash afeb514)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	✅ 🧪 wincairo-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
✅ 🧪 services	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress	❌ 🧪 api-gtk
✅ 🛠 🧪 merge	✅ 🛠 watch
	✅ 🛠 watch-sim

https://bugs.webkit.org/show_bug.cgi?id=274272 rdar://121395049 Reviewed by Ryan Haddad. Bring up of OpenSource visionOS builders and testers. * Tools/CISupport/build-webkit-org/config.json: * Tools/CISupport/build-webkit-org/factories.py: (TestFactory.__init__): * Tools/CISupport/build-webkit-org/factories_unittest.py: (TestExpectedBuildSteps): * Tools/CISupport/build-webkit-org/loadConfig.py: (loadBuilderConfig): * Tools/CISupport/build-webkit-org/public_html/dashboard/Scripts/Dashboard.js: * Tools/CISupport/build-webkit-org/public_html/dashboard/Scripts/WebKitBuildbot.js: (WebKitBuildbot): * Tools/CISupport/build-webkit-org/public_html/dashboard/Styles/Main.css: (table.queue-grid tr.platform.visionos-simulator-1 img.logo): (table.queue-grid tr.platform.visionos-1 img.logo): * Tools/CISupport/build-webkit-org/steps.py: (CustomFlagsMixin.customBuildFlag): (CustomFlagsMixin.appendCustomBuildFlags): (CustomFlagsMixin.appendCustomTestingFlags): (CompileWebKit): (CompileWebKit.evaluateCommand): (PrintConfiguration.run): * Tools/CISupport/build-webkit-org/wkbuild.py: (_should_file_trigger_build): * Tools/CISupport/build-webkit-org/wkbuild_unittest.py: (ShouldBuildTest): (ShouldBuildTest.test_should_build): Canonical link: https://commits.webkit.org/279249@main

webkit-commit-queue · 2024-05-24T01:40:28Z

Committed 279249@main (b4e487b): https://commits.webkit.org/279249@main

Reviewed commits have been landed. Closing PR #28667 and removing active labels.

robert-jenner requested review from aj062, JonWBedard and ryanhaddad as code owners May 16, 2024 19:00

robert-jenner self-assigned this May 16, 2024

robert-jenner requested a review from briannafan as a code owner May 16, 2024 19:00

robert-jenner added the Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases label May 16, 2024

aj062 reviewed May 16, 2024

View reviewed changes

Tools/CISupport/build-webkit-org/factories.py Outdated Show resolved Hide resolved

robert-jenner force-pushed the eng/121395049 branch from aa2cbda to caf4907 Compare May 16, 2024 19:24

robert-jenner force-pushed the eng/121395049 branch from caf4907 to 715011b Compare May 16, 2024 19:40

robert-jenner force-pushed the eng/121395049 branch from 715011b to 7814be8 Compare May 16, 2024 20:23

robert-jenner force-pushed the eng/121395049 branch from 7814be8 to fe5fc89 Compare May 16, 2024 20:51

ryanhaddad approved these changes May 16, 2024

View reviewed changes

Tools/CISupport/build-webkit-org/factories.py Outdated Show resolved Hide resolved

robert-jenner force-pushed the eng/121395049 branch from fe5fc89 to 3c1756a Compare May 16, 2024 22:42

robert-jenner added safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks and removed safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks labels May 16, 2024

robert-jenner force-pushed the eng/121395049 branch 2 times, most recently from 8a4beaf to 3938d0a Compare May 23, 2024 00:04

robert-jenner force-pushed the eng/121395049 branch from 3938d0a to 32ef387 Compare May 23, 2024 01:07

robert-jenner force-pushed the eng/121395049 branch from 32ef387 to e5d8051 Compare May 23, 2024 01:31

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label May 23, 2024

robert-jenner removed the merging-blocked Applied to prevent a change from being merged label May 23, 2024

robert-jenner force-pushed the eng/121395049 branch from e5d8051 to afeb514 Compare May 23, 2024 16:36

robert-jenner added the merge-queue Applied to send a pull request to merge-queue label May 24, 2024

webkit-commit-queue force-pushed the eng/121395049 branch from afeb514 to b4e487b Compare May 24, 2024 01:40

webkit-commit-queue merged commit b4e487b into WebKit:main May 24, 2024

webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label May 24, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[build.webkit.org] Bring up open source visionOS builders and testers #28667

[build.webkit.org] Bring up open source visionOS builders and testers #28667

robert-jenner commented May 16, 2024 •

edited by webkit-early-warning-system

webkit-early-warning-system commented May 16, 2024 •

edited

aj062 commented May 16, 2024

webkit-early-warning-system commented May 16, 2024 •

edited

webkit-early-warning-system commented May 16, 2024 •

edited

webkit-early-warning-system commented May 16, 2024 •

edited

webkit-early-warning-system commented May 16, 2024 •

edited

ryanhaddad left a comment

webkit-early-warning-system commented May 16, 2024 •

edited

webkit-early-warning-system commented May 23, 2024 •

edited

webkit-early-warning-system commented May 23, 2024 •

edited

webkit-early-warning-system commented May 23, 2024 •

edited

webkit-early-warning-system commented May 23, 2024 •

edited

webkit-commit-queue commented May 24, 2024

[build.webkit.org] Bring up open source visionOS builders and testers #28667

[build.webkit.org] Bring up open source visionOS builders and testers #28667

Conversation

robert-jenner commented May 16, 2024 • edited by webkit-early-warning-system

b4e487b

webkit-early-warning-system commented May 16, 2024 • edited

aj062 commented May 16, 2024

webkit-early-warning-system commented May 16, 2024 • edited

webkit-early-warning-system commented May 16, 2024 • edited

webkit-early-warning-system commented May 16, 2024 • edited

webkit-early-warning-system commented May 16, 2024 • edited

ryanhaddad left a comment

Choose a reason for hiding this comment

webkit-early-warning-system commented May 16, 2024 • edited

webkit-early-warning-system commented May 23, 2024 • edited

webkit-early-warning-system commented May 23, 2024 • edited

webkit-early-warning-system commented May 23, 2024 • edited

webkit-early-warning-system commented May 23, 2024 • edited

webkit-commit-queue commented May 24, 2024

robert-jenner commented May 16, 2024 •

edited by webkit-early-warning-system

`b4e487b`

webkit-early-warning-system commented May 16, 2024 •

edited

webkit-early-warning-system commented May 16, 2024 •

edited

webkit-early-warning-system commented May 16, 2024 •

edited

webkit-early-warning-system commented May 16, 2024 •

edited

webkit-early-warning-system commented May 16, 2024 •

edited

webkit-early-warning-system commented May 16, 2024 •

edited

webkit-early-warning-system commented May 23, 2024 •

edited

webkit-early-warning-system commented May 23, 2024 •

edited

webkit-early-warning-system commented May 23, 2024 •

edited

webkit-early-warning-system commented May 23, 2024 •

edited