-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WebGPU] RenderBundleEncoder::endCurrentICB may assert in ASAN builds on invalid bundle encoder #28668
Merged
webkit-commit-queue
merged 1 commit into
WebKit:main
from
mwyrzykowski:eng/WebGPU-RenderBundleEncoderendCurrentICB-may-assert-in-ASAN-builds-on-invalid-bundle-encoder
May 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EWS run on previous version of this PR (hash 1fc727f) |
mwyrzykowski
force-pushed
the
eng/WebGPU-RenderBundleEncoderendCurrentICB-may-assert-in-ASAN-builds-on-invalid-bundle-encoder
branch
from
May 16, 2024 19:11
1fc727f
to
bfdd297
Compare
EWS run on previous version of this PR (hash bfdd297) |
djg
approved these changes
May 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
webkit-commit-queue
force-pushed
the
eng/WebGPU-RenderBundleEncoderendCurrentICB-may-assert-in-ASAN-builds-on-invalid-bundle-encoder
branch
from
May 18, 2024 16:17
bfdd297
to
a14271a
Compare
mwyrzykowski
removed
the
merge-queue
Applied to send a pull request to merge-queue
label
May 20, 2024
mwyrzykowski
force-pushed
the
eng/WebGPU-RenderBundleEncoderendCurrentICB-may-assert-in-ASAN-builds-on-invalid-bundle-encoder
branch
from
May 20, 2024 15:02
a14271a
to
0abeda4
Compare
webkit-ews-buildbot
added
merging-blocked
Applied to prevent a change from being merged
and removed
merge-queue
Applied to send a pull request to merge-queue
labels
May 20, 2024
mwyrzykowski
added
unsafe-merge-queue
Applied to send a pull request to merge-queue, but skip building and testing
and removed
merging-blocked
Applied to prevent a change from being merged
labels
May 20, 2024
β¦ on invalid bundle encoder https://bugs.webkit.org/show_bug.cgi?id=274271 <radar://128064942> Reviewed by Dan Glastonbury. There is an ASAN assert in Vector::grow(sz) to ensure sz >= the current size, which will not be true when replaying commands from an invalid RenderBundleEncoder. But we shouldn't replay commands from an invalid RenderBundleEncoder in the first place, so return early if the encoder is invalid. * LayoutTests/fast/webgpu/fuzz-274271-expected.txt: Added. * LayoutTests/fast/webgpu/fuzz-274271.html: Added. * LayoutTests/TestExpectations: Add regression test. * Source/WebGPU/WebGPU/RenderBundleEncoder.h: (WebGPU::RenderBundleEncoder::isValid const): Deleted. * Source/WebGPU/WebGPU/RenderBundleEncoder.mm: (WebGPU::RenderBundleEncoder::endCurrentICB): (WebGPU::RenderBundleEncoder::isValid const): (WebGPU::RenderBundleEncoder::replayCommands): Canonical link: https://commits.webkit.org/278997@main
webkit-commit-queue
force-pushed
the
eng/WebGPU-RenderBundleEncoderendCurrentICB-may-assert-in-ASAN-builds-on-invalid-bundle-encoder
branch
from
May 20, 2024 16:57
0abeda4
to
21e320d
Compare
Committed 278997@main (21e320d): https://commits.webkit.org/278997@main Reviewed commits have been landed. Closing PR #28668 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Applied to send a pull request to merge-queue, but skip building and testing
label
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
21e320d
0abeda4
π§ͺ wincairo-testsπ§ͺ gtk-wk2π π§ͺ merge