Disable telemetry for known notifications #28677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvollan
added
the
WebKit Process Model
|
EWS run on previous version of this PR (hash 576baac) |
szewai
reviewed
May 17, 2024
| plistbuddy Add :com.apple.private.darwin-notification.introspect:17 string com.apple.system.lowpowermode | ||
| plistbuddy Add :com.apple.private.darwin-notification.introspect:18 string com.apple.system.timezone | ||
| plistbuddy Add :com.apple.private.darwin-notification.introspect:19 string com.apple.zoomwindow | ||
| plistbuddy Add :com.apple.private.darwin-notification.introspect:8 string com.apple.accessibility.cache.guided.access |
There was a problem hiding this comment.
This seems not in const Vector<ASCIILiteral> notificationMessages, is it forwarded?
|
@pvollan Any update on this? |
Ah, sorry for the delayed response. This is actually a notification that is used only in-process, so I don't believe we need to forward this one. And the sandbox change should not be required either, then. I will update the patch. Thanks for reviewing, all! |
pvollan
force-pushed
the
eng/Disable-telemetry-for-known-notifications
branch
from
576baac
to
8cd5ddf
Compare
|
EWS run on previous version of this PR (hash 8cd5ddf) |
pvollan
force-pushed
the
eng/Disable-telemetry-for-known-notifications
branch
from
8cd5ddf
to
632a68e
Compare
|
EWS run on current version of this PR (hash 632a68e) |
webkit-ews-buildbot
added
the
merging-blocked
szewai
approved these changes
May 21, 2024
cdumez
added
merge-queue
https://bugs.webkit.org/show_bug.cgi?id=274279 rdar://128213400 Reviewed by Sihui Liu. Disable telemetry for notifications that we know are being observed in the WebContent process. For in-process notifications, we do not need to forward them from the UI process. * Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in: * Source/WebKit/Scripts/process-entitlements.sh: * Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm: (WebKit::WebProcessPool::registerNotificationObservers): * Source/WebKit/WebProcess/com.apple.WebProcess.sb.in: Canonical link: https://commits.webkit.org/279065@main
webkit-commit-queue
force-pushed
the
eng/Disable-telemetry-for-known-notifications
branch
from
632a68e
to
00575a1
Compare
|
Committed 279065@main (00575a1): https://commits.webkit.org/279065@main Reviewed commits have been landed. Closing PR #28677 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
00575a1
632a68e