[curl] Obtain the Content-Length and request header size ourselves.

[kshukuwa]

8a9f0f2

[curl] Obtain the Content-Length and request header size ourselves.
https://bugs.webkit.org/show_bug.cgi?id=272445

Reviewed by Fujii Hironori.

Since curl 8.7.0, CURLINFO_CONTENT_LENGTH_DOWNLOAD_T and
CURLINFO_REQUEST_SIZE  are no longer available in the header callback.
For this reason, we will obtain the Content-Length and request header
size ourselves.

* LayoutTests/platform/wincairo/TestExpectations:
* Source/WebCore/platform/network/curl/CurlContext.cpp:
(WebCore::CurlHandle::addExtraNetworkLoadMetrics):
* Source/WebCore/platform/network/curl/CurlContext.h:
* Source/WebCore/platform/network/curl/CurlRequest.cpp:
(WebCore::CurlRequest::setupTransfer):
(WebCore::CurlRequest::didReceiveHeader):
(WebCore::CurlRequest::didReceiveDebugInfo):
(WebCore::CurlRequest::networkLoadMetrics):
(WebCore::CurlRequest::getContentLength):
* Source/WebCore/platform/network/curl/CurlRequest.h:

Canonical link: https://commits.webkit.org/279553@main

7c61b98

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	✅ 🧪 wincairo-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge	✅ 🛠 watch-sim

[webkit-early-warning-system]

EWS run on current version of this PR (hash 7c61b98)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	✅ 🧪 wincairo-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge	✅ 🛠 watch-sim

[fujii]

Is this a libcurl bug? Did you report? Do you think this patch should be landed even if the upstream libcurl will fix the bug?

[kshukuwa]

I reported this but have not received any response. So I don't know if it's a bug in libcurl or not.
https://curl.se/mail/lib-2024-05/0028.html

On the other hand, the description of curl_easy_getinfo says " Use this function after a performed transfer if you want to get transfer related data. ", so it may not be recommended to call curl_easy_getinfo within a header callback.

https://curl.se/libcurl/c/curl_easy_getinfo.html

In that case, this patch may be the right direction. On the other hand, there is some information that can only be obtained by curl_easy_getinfo, so I think it is better to continue using it for the information that can be obtained.

[kshukuwa]

Could you please add the merge-queue label to merge this PR?

[webkit-commit-queue]

Committed 279553@main (8a9f0f2): https://commits.webkit.org/279553@main

Reviewed commits have been landed. Closing PR #28693 and removing active labels.