Wayland colorpicking

[madjesc]

Summary / How this PR fixes the problem?

Implementing colorpicking in Wayland using libportal

Steps to Test

Screenshots

Known Issues / Things To Do

• Handle pick_color_finish exception
• Test in Xorg

This PR fixes/implements the following bugs/features:

• Fixes Color picker not working under Wayland #598

[madjesc]

It not works with the master update, fixing

[madjesc]

Now it works, using libportal 4.0
And now the Utils.ColorPicker class is not a window,
is a class that emmits a signal when the colorpicking is done.

[Alecaddd]

@Mkefs Hi, thank you so much for your contribution.
This is great, but indeed it shouldn't break this feature for X11 users, which are our primary target for now.
Any chance of making this work for both?

[madjesc]

@Mkefs Hi, thank you so much for your contribution.
This is great, but indeed it shouldn't break this feature for X11 users, which are our primary target for now.
Any chance of making this work for both?

Ok, I'll try

[Alecaddd]

Converting this to a Draft PR since it's not ready for a full review or to be merged.

[madjesc]

It works in Xorg.
Tested on Gnome 3.38 on Debian bullseye

[Alecaddd]

Awesome, I'll review this later today.
Thanks!

[Alecaddd]

The build is busted.

[Alecaddd]

@Mkefs you wrote Handle screenshot exception in the list of things to do.
What did you mean by that? Is that still an actionable item you want to tackle?

[madjesc]

@Mkefs you wrote Handle screenshot exception in the list of things to do.
What did you mean by that? Is that still an actionable item you want to tackle?

libportal pick_color_finish throws a GLib.Error if something went wrong. In ColorPicker.vala I don't handle this exception thus it does nothing when something wrong in libportal happens. Although it's harmless it should popup something to the user saying that something went wrong, or just log it to the console

// Libportal color picking finish 
// try {
GLib.Variant v = portal.pick_color_finish (result);
// } catch (GLib.Error e) { ... /* <-- Do something */ }

[Alecaddd]

I can deal with that, thanks.
Another question. Is libportal available anywhere as an installable package with apt?
I know it's kind of a silly question as we're fully transitioning to a full faltpak based build, but for those who locally build this via meson I'd like to avoid forcing them to manually install libportal.

[madjesc]

I can deal with that, thanks.
Another question. Is libportal available anywhere as an installable package with apt?
I know it's kind of a silly question as we're fully transitioning to a full faltpak based build, but for those who locally build this via meson I'd like to avoid forcing them to manually install libportal.

Via apt in debian no, in other distros like Void Linux, Arch and I think Ubuntu too, yes.
In debian it's in the unstable branch.

[Alecaddd]

This works but it removes the fundamental feature that makes the color picker tool easy to use and superior to the default color picker. The zoom (magnifying glass) effect.
That is vital and we need to keep it.

[madjesc]

Ok, I will try to do it using libportal

[mbfraga]

Awesome stuff! I use wayland on my dev machine that I use for Akira...so this is quite nice :P Will review.

[mbfraga]

Works on wayland (what I use now). So it definitely gets my upvote.