Fixed the error when bbox dimensions gets less than 0 or greater than 1 #1278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
POONAM2015
commented
Sep 6, 2022
POONAM2015
commented
|
We can not change bboxes silently, because these changes might be incorrect in some cases. Better to add flag |
…boxes should be forcefully clamped to lie between 0 and 1
|
I have added the parameter |
Dipet
reviewed
Sep 6, 2022
Comment on lines
121
to
125
| def convert_from_albumentations(self, data: Sequence, rows: int, cols: int) -> List[BoxType]: | ||
| return convert_bboxes_from_albumentations(data, self.params.format, rows, cols, check_validity=True) | ||
| return convert_bboxes_from_albumentations(data, self.params.format, rows, cols, check_validity=True, clamp_bbox=self.params.clamp_bbox) | ||
|
|
||
| def convert_to_albumentations(self, data: Sequence[BoxType], rows: int, cols: int) -> List[BoxType]: | ||
| return convert_bboxes_to_albumentations(data, self.params.format, rows, cols, check_validity=True) |
There was a problem hiding this comment.
You added this parameter to wrong function. You changed to function, but added param to from function. Please add small test to check that this functionality works coreectly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.