Add zsh, fish & python cleaners. #1229
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naxl
approved these changes
Oct 1, 2022
az0
requested changes
Dec 29, 2022
| <option id="history"> | ||
| <label>History</label> | ||
| <description>Delete the command history</description> | ||
| <action command="delete" search="file" path="~/.pythonhist"/> |
There was a problem hiding this comment.
Which system are you testing on? On Ubuntu 22.04, I have ~/.python_history. Please add this one.
| --> | ||
| <cleaner id="python" os="unix"> | ||
| <label>Python</label> | ||
| <description>Programing language</description> |
There was a problem hiding this comment.
Suggested change
| <description>Programing language</description> | |
| <description>Programming language</description> |
| @@ -0,0 +1,30 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <!-- | |||
There was a problem hiding this comment.
99+% of Linux users do not use zsh or fish, so please submit those to https://github.com/bleachbit/cleanerml/ . Otherwise, I can accept it here and move them afterwards.
Bash is preinstalled on a typical Linux system, and here is a reference point
https://trends.google.com/trends/explore?geo=US&q=zsh,bash
| <option id="history"> | ||
| <label>History</label> | ||
| <description>Delete the command history</description> | ||
| <action command="delete" search="file" path="~/.zsh_history"/> |
There was a problem hiding this comment.
From https://www.redhat.com/sysadmin/favorite-shell Bash takes 779/1441=54% and Zsh 377/1441=26%
These are users who would go through the process of installing BleachBit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add cleanders:
zsh history
fish history
python3 history