NSIS.UMUI.Complete (Suggested solution!) (Review wanted) #527

Tobias-B-Besemer · 2019-03-31T07:04:30Z

Moved strings into new, seperate file bleachbit_lang.nsh
Added multi-language support for strings
Created bleachbit_nsis_general.pot
Created bleachbit_nsis_multiuser.pot

- Moved strings into new, seperate file bleachbit_lang.nsh - Added multi-language support for strings - Created bleachbit_nsis_general.pot - Created bleachbit_nsis_multiuser.pot

Tobias-B-Besemer · 2019-03-31T07:05:03Z

I hope I did it right...

Lets give it a try! ;-)

az0 · 2019-03-31T13:56:15Z

Did you try installation from this build https://ci.appveyor.com/project/az0/bleachbit/builds/23483634/artifacts ?

az0 · 2019-03-31T13:57:06Z

windows/bleachbit_nsis_general.pot

+msgstr "Shred with BleachBit"
+
+msgid "BLEACHBIT_UPGRADE_UNINSTALL"
+msgstr "${prodname} is already installed. Click 'OK' to uninstall the old version before \ upgrading, or click 'Cancel' to abort the upgrade."


Does the slash \ belong in the middle here?

I copied the string from you. Is it a linebreak in NSIS?

OK, written in this form, it is no line-break! Also: NSIS do line-breaks by its own! So I removed the " \ "...

Tobias-B-Besemer · 2019-04-01T02:14:36Z

Did you try installation from this build https://ci.appveyor.com/project/az0/bleachbit/builds/23483634/artifacts ?

No.

- Included FileFunc.nsh for e.g. command line arguments managment - Made the remaining English texts to variables - Added icon to Windows Explorer Shell Extension - Added descriptions to the installer options - First command line arguments managment - Own help page by command line - New bleachbit_lang.nsh - New German Translation - New bleachbit_nsis_general.pot

Fixing syntax

Fixing + SetErrorLevel

Tobias-B-Besemer · 2019-04-01T11:09:17Z

@az0, what do you mean with FIXME later: Restore QuietUninstallString ???
Restore QuietUninstallString if it was used before BB got de-installed because of upgrade?
Only option I see: Use of a command line parameter to pars the information to the installer...
Should we do this?

Tobias-B-Besemer · 2019-04-01T11:14:24Z

Sorry, no, we can do it with SetErrorLevel... ^^

- Variables "Section" -> "Component" - Restore QuietUninstallString - First implementation "/no-desktop-shortcut"

Fix syntax

Tobias-B-Besemer · 2019-04-01T19:52:24Z

OK, I doing now tests...

Tobias-B-Besemer · 2019-04-01T21:24:55Z

I recognized that there exist also the bug that you can abort the uninstall of the previous version and can install anyway. I will try to fix that, too.

Tobias-B-Besemer · 2019-04-16T11:16:51Z

Just do a short review of it, not in deep, only to look that I don't delete the complete PC with my installer. ^^ Then land this patch - this installer is (with all his remaining bugs) already much better then the current one!

At this time I would accept it into its own branch

That's great!

I think it would be really nice, if we get this landed/stable till v2.4.0.xxxx.

I am skipping to version 3.0. The reason is it is becoming urgent to change to GTK 3 and Python 3. The first change is GTK 3, and there is a branch for that. These could require changes to the NSIS installer, and I am hoping to avoid merge conflicts.

My plan is to be finished with the NSIS Installer in the next 2-3 weeks. If I integrate them in the Master Branch, or a GTK 3 Branch doesn't matter much for me... NSIS change nothing on the BleachBit Python Code and the GTK 3 Branch gets integrated into the Master Branch again... My plan was to have a new, fresh, funky, professional installer for GTK 3, that the new GUI gets also reflected by the installer...

But the To-Dos-List only includes things I can't do alone!

If they are not done, will there be regressions against version 2.0 or signficiant new bugs?

No! Mainly it's get AppVeyor to build the installers again...
You can have a look into "bleachbit.nsi_-_to-dos.txt" that is now pushed with this PR....

Main changes are Bug Fixes, Add/Remove Functionality, switch "/no-desktop-shortcut", QuietUninstallString/SystemComponent & general improvements.

The "bug fixes" and "general improvements" are not clear enough to either test now or to explain in the release notes for the next final release. If the change is tiny (such as a cosmetic change), then it does not need to be documented.

You can bring it together with "better 'current user'/'all users' system integration".

If end users would notice an enhancement or bug fix, then it's worth document for the release notes.

If a change could cause a regression or maybe would not work equally well on all systems, then I'd prefer to note it for testing.

Please have a look into "bleachbit.nsi_-_tests.txt" that includes details questions/tests to Beta-/Alpha-Tester about the changes in NSIS.

Benefit: The code gets in future managed/updated by someone else who is really better then me! ^^

In general, I consider this a great benefit. I am a proponent of the DRY programming principle.

Andrew, if you decide to use UMUI (what I suggest you), then you should update NSIS on AppVeyor with a build from here: https://sourceforge.net/projects/ultramodernui/files/UltraModernUI/UltraModernUI%202.0b5/
Else we don't get AppVeyor to build the NSIS File that include the UMUI Code...

This means the screenshots are from your personal system because UMUI does not currently work on AppVeyor, correct?

Yes! I already improved the design a bit more, but yes, that's what I have compiled!

I prefer to use the mainline NSIS. Looking at the Git repositories for UMUI and the mainline NSIS, it seems UMUI maybe is out of date. Also, it's not clear it will stay up to date.

Last update to UMUI was January 2019! GitHub is just a new copy/place for the source! Version 1.00 beta 1 was released March 20, 2005! I'm pretty sure the project will persist! ^^
Here is the official home page: http://ultramodernui.sourceforge.net/
Main things seems to be done (like for NSIS in general, too) on sourceforge.net...
If you trust my evaluation and go with me the UMUI way, I can remove a lot of my code (that related to the Add/Remove Feature), bring a new professional skin to the installer and additional features...
...if you stay on MUI2, you will have more to review and still a oldish interface and I must revert my changes belonging to UMUI... :-/

Tobias-B-Besemer · 2019-04-16T13:23:33Z

Did you fix this silent install bug? I'd like him to test your version, but there hasn't been a successful build on AppVeyor for 13 days

Yes, should be fixed in my builds! ^^ But I write you more to it in the other issue...
I think I will upload my EXEs to Google Drive for testing... ;-)
That there are no more successful builds on AppVeyor comes because you need to change some things on AppVeyor that my builds get generated again... :-/

Tobias-B-Besemer · 2019-04-16T13:36:49Z

With this Link you should get access to my BleachBit Project Files:
https://drive.google.com/drive/folders/1ZbzJimB2rPPaC9zen-5_8frIX5RlCN4M?usp=sharing

Tobias-B-Besemer · 2019-04-16T16:21:27Z

OK, new builds with MUI2 & UMUI are online! ;-)

You can give it a try!

Tobias-B-Besemer · 2019-04-18T13:37:58Z

Andrew, I reverted now the UMUI changes on the snapshot I had and "finished" the MUI2 builds...

Parallel I mad a other branch on my local disc and worked (and "finished") the UMUI builds... ^^

So there are now two kind of builds: MUI2 & UMUI ^^

In the following I will post here some screenshots from my latest UMUI builds to convince you ^^ that UMUI is the better solution... ^^

...then I'm going to push here the latest UMUI sources...

Parallel I'm opening a new PR with the MUI2 source...

I have already a PR "NSIS.Merge (Review wanted)" open...
There I try to go with you the first steps together.
(MUI2 & UMUI build have many in common and I will push small peaces for you... ^^)

Btw.: "My work is so far done!" and I should have testers and feedback about bugs and suggestions to improve the builds more...

Tobias-B-Besemer · 2019-04-18T13:52:05Z

OK, one really nice thing beside the ability to skin the installer/uninstaller and that IMHO UMUI looks more like a professional solution... ^^ (...and BleachBit reserves that!) ...is, that you have all in one Window! The language dialog, Add/Remove, even the build-in Updater! ^^

Here is a screenshot of the build-in Updater with my/our custom warning:

UMUI have a "nice" Install Type selection and a "menu" for ADD/Remove that looks the same:
(The modify page have also the warning, again.)

I have even renamed a bit the Section Text that the "Confirm Installation" Dialog looks good... ^^

Give it a try! My newest builds are here for download: (Also MUI2 builds...)
https://drive.google.com/drive/folders/1ZbzJimB2rPPaC9zen-5_8frIX5RlCN4M?usp=sharing

+ GTK3 Support + Makefiles.bat + Autostart: Show minimized

Tobias-B-Besemer · 2019-04-24T02:51:39Z

Latest builds:
https://drive.google.com/drive/u/0/folders/1ZbzJimB2rPPaC9zen-5_8frIX5RlCN4M

Tobias-B-Besemer · 2019-04-24T20:14:12Z

New builds are available:
https://drive.google.com/drive/u/0/folders/1ZbzJimB2rPPaC9zen-5_8frIX5RlCN4M

az0 · 2019-11-02T03:32:10Z

@Tobias-B-Besemer
Is this pull request ready for review? I am arranging for someone to review it in depth.

az0 · 2019-11-02T03:34:03Z

@Tobias-B-Besemer

There is this error from AppVeyor

Processing script file: "windows\bleachbit.nsi" (ACP)
2019-04-24 20:13:26 - ERROR - !include: could not find: "NsisIncludeOthers\German.nsh"
Error in script "windows\bleachbit.nsi" on line 258 -- aborting creation process
2019-04-24 20:13:26 - ERROR - windows\BleachBit-2.3.0.0-Setup.exe not found
Command exited with code 1

Also, there are many merge conflicts.

What do you think of me holding off the review until you can review these issues?

Tobias-B-Besemer · 2019-11-02T16:57:17Z

Generally the installer is ready for review.
Can't remember the old errors, but they should be gone.
Have to make a new push with the BB3.0 changes. Removed the 3 languages you removed, but haven't pushed no more...
The source isn't lint yet, but I think we can lint it later, 'cause it compiles and work as it is...
You should first switch to the 3, or 4 dot versioning, 'cause AppVeyor will not finish else. After that I must maybe do a push again, to get our changes (my suggested ones and then your really done) sync...
Would suggest you to start review with the UI. Download last version and have a look on feel & handle and give me feedback to it...

Tobias-B-Besemer · 2019-11-02T17:05:13Z

Oh, and you have to install the UMUI installer for this PR!
UMUI installer is basically the same as the normal installer but have included some plugins.
The UMUI installer is able to compile but versions...
As you know, I highly recommend the UMUI installer because of look, feel and simpler code by same functionality...
...and the project is also ~10yo and persists...

Tobias-B-Besemer · 2019-11-11T09:40:31Z

Just for the notes, 3 things open to be done:

Tobias-B-Besemer · 2019-11-11T14:55:46Z

The following PR will include the following changes:

Remove the 3 removed languages and update the NSIS files to the latest version;
Update files in NsisInclude - this should fix some of the conflicts
(Used version: Adding some notes to the files for version management of downstream… Drizin/NsisMultiUser#24);
Update NsisMultiUserLang.nsh
(Fix language Georgian Drizin/NsisMultiUser#25),
(Fixing language Hungarien Drizin/NsisMultiUser#26),
(Fixing language Italien Drizin/NsisMultiUser#27),
(Fixing language Scotsgaelic Drizin/NsisMultiUser#28),
(Fixing language SerbianLatin Drizin/NsisMultiUser#29);
Update the forgotten files in NsisPluginsUnicode;
Remove "XPStyle on" as noted in Some colors seems to be defined in UMUI SuperPat45/UltraModernUI#12 and add a comment for future to it.

Changes: bleachbit#527 (comment)

Better multi-language support

7065cef

- Moved strings into new, seperate file bleachbit_lang.nsh - Added multi-language support for strings - Created bleachbit_nsis_general.pot - Created bleachbit_nsis_multiuser.pot

Tobias-B-Besemer mentioned this pull request Mar 31, 2019

NSIS: Fixing the gaps in the translation, adding description to components, add icon to shell extension #528

Open

az0 reviewed Mar 31, 2019

View reviewed changes

Tobias-B-Besemer mentioned this pull request Apr 1, 2019

Docu "Create packages" (Windows EXE + Installer) bleachbit/wishlist#38

Open

Tobias-B-Besemer added 5 commits April 1, 2019 11:14

v2.0.1

9d30bfb

Fixing syntax

v2.0.2

a588e54

Fixing syntax

v2.0.3

0837f49

v2.0.4

52c1a84

Fixing + SetErrorLevel

Tobias-B-Besemer added 12 commits April 1, 2019 14:38

v2.1.0

e7ec240

- Variables "Section" -> "Component" - Restore QuietUninstallString - First implementation "/no-desktop-shortcut"

v2.1.1

44ecc59

v2.1.2

b76135b

Fix syntax

v2.1.3

e9daff5

v2.3.1003

631e61c

v2.3.1004

bde3744

v2.3.1005

a8d4535

v2.3.1006

0bbe6a0

v2.3.1007

6df0ab4

v2.3.1008

84eb5ff

v2.3.1009

9b45592

v2.3.1010

bcf423e

Tobias-B-Besemer added 2 commits April 1, 2019 23:37

v2.3.1011

4188a9e

v2.3.1012

138f7cc

v2.3.0.1059 - 2019-04-18

e77abf3

Tobias-B-Besemer changed the title ~~NSIS (Status: Feedback wanted)~~ NSIS (Review wanted) Apr 18, 2019

GTK3 Support / Makefiles.bat

b2cdcef

+ GTK3 Support + Makefiles.bat + Autostart: Show minimized

Gray Skin

fd65d16

az0 force-pushed the master branch from 372967a to ef31c9d Compare July 26, 2019 04:04

az0 force-pushed the master branch from e4f1281 to 3363737 Compare September 25, 2019 04:26

Tobias-B-Besemer mentioned this pull request Oct 29, 2019

Error message "There is no disk in the drive" #651

Closed

Tobias-B-Besemer added 4 commits November 11, 2019 17:13

Bring lates changes to PR

b72e07e

Changes: bleachbit#527 (comment)

Lint version

6f628f2

"LegalCopyright" = "Andrew Ziem"

e6db842

Remove the "XPStyle On"

db3a71a

Tobias-B-Besemer changed the title ~~NSIS (Review wanted)~~ NSIS.UMUI (Suggest solution!) (Review wanted) Nov 30, 2019

Tobias-B-Besemer changed the title ~~NSIS.UMUI (Suggest solution!) (Review wanted)~~ NSIS.UMUI.Complete (Suggest solution!) (Review wanted) Nov 30, 2019

Tobias-B-Besemer changed the title ~~NSIS.UMUI.Complete (Suggest solution!) (Review wanted)~~ NSIS.UMUI.Complete (Suggested solution!) (Review wanted) Nov 30, 2019

az0 force-pushed the master branch from e3d11aa to 63fdde5 Compare November 4, 2020 05:03

az0 force-pushed the master branch from 64fd727 to 19a4780 Compare August 9, 2021 03:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

NSIS.UMUI.Complete (Suggested solution!) (Review wanted) #527

NSIS.UMUI.Complete (Suggested solution!) (Review wanted) #527

Tobias-B-Besemer commented Mar 31, 2019

Tobias-B-Besemer commented Mar 31, 2019

az0 commented Mar 31, 2019

az0 Mar 31, 2019

Tobias-B-Besemer Apr 1, 2019

Tobias-B-Besemer Apr 2, 2019

Tobias-B-Besemer commented Apr 1, 2019

Tobias-B-Besemer commented Apr 1, 2019

Tobias-B-Besemer commented Apr 1, 2019

Tobias-B-Besemer commented Apr 1, 2019

Tobias-B-Besemer commented Apr 1, 2019

Tobias-B-Besemer commented Apr 16, 2019

Tobias-B-Besemer commented Apr 16, 2019

Tobias-B-Besemer commented Apr 16, 2019

Tobias-B-Besemer commented Apr 16, 2019

Tobias-B-Besemer commented Apr 18, 2019

Tobias-B-Besemer commented Apr 18, 2019

Tobias-B-Besemer commented Apr 24, 2019

Tobias-B-Besemer commented Apr 24, 2019

az0 commented Nov 2, 2019

az0 commented Nov 2, 2019

Tobias-B-Besemer commented Nov 2, 2019 •

edited

Tobias-B-Besemer commented Nov 2, 2019 •

edited

Tobias-B-Besemer commented Nov 11, 2019

Tobias-B-Besemer commented Nov 11, 2019 •

edited

NSIS.UMUI.Complete (Suggested solution!) (Review wanted) #527

Are you sure you want to change the base?

NSIS.UMUI.Complete (Suggested solution!) (Review wanted) #527

Conversation

Tobias-B-Besemer commented Mar 31, 2019

Tobias-B-Besemer commented Mar 31, 2019

az0 commented Mar 31, 2019

az0 Mar 31, 2019

Choose a reason for hiding this comment

Tobias-B-Besemer Apr 1, 2019

Choose a reason for hiding this comment

Tobias-B-Besemer Apr 2, 2019

Choose a reason for hiding this comment

Tobias-B-Besemer commented Apr 1, 2019

Tobias-B-Besemer commented Apr 1, 2019

Tobias-B-Besemer commented Apr 1, 2019

Tobias-B-Besemer commented Apr 1, 2019

Tobias-B-Besemer commented Apr 1, 2019

Tobias-B-Besemer commented Apr 16, 2019

Tobias-B-Besemer commented Apr 16, 2019

Tobias-B-Besemer commented Apr 16, 2019

Tobias-B-Besemer commented Apr 16, 2019

Tobias-B-Besemer commented Apr 18, 2019

Tobias-B-Besemer commented Apr 18, 2019

Tobias-B-Besemer commented Apr 24, 2019

Tobias-B-Besemer commented Apr 24, 2019

az0 commented Nov 2, 2019

az0 commented Nov 2, 2019

Tobias-B-Besemer commented Nov 2, 2019 • edited

Tobias-B-Besemer commented Nov 2, 2019 • edited

Tobias-B-Besemer commented Nov 11, 2019

Tobias-B-Besemer commented Nov 11, 2019 • edited

Tobias-B-Besemer commented Nov 2, 2019 •

edited

Tobias-B-Besemer commented Nov 2, 2019 •

edited

Tobias-B-Besemer commented Nov 11, 2019 •

edited