NSIS.MUI2.General-Merge (Review wanted!) #537
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also: * New header * A bit of code re-sort
Tobias-B-Besemer
changed the title
|
@az0, is there any regression open on this very small PR (first of all NSIS changes in very small piece), or why you haven't checked in it by now? |
Tobias-B-Besemer
changed the title
Tobias-B-Besemer
changed the title
|
OK, finally this PR build without merge conflicts, again! :-) |
Tobias-B-Besemer
changed the title
|
@az0, do you have any questions or regressions to this PR ??? |
|
This has a merge conflict in |
|
OK, I look how I can fix that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make progress and make it easier for you, some changes as single PRs...