fix: Add a empty state msg when there is no recently opened files #4292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This Pull Request targets Consider targeting |
nikku
reviewed
May 16, 2024
| @@ -210,7 +210,7 @@ class MenuBuilder { | |||
| enabled: true, | |||
| submenu: Menu.buildFromTemplate([ | |||
| { | |||
| label: 'Reopen Last File', | |||
| label: this.options.state.closedTabs.length > 0 ? 'Reopen Last File' : 'No Files Opened', | |||
There was a problem hiding this comment.
Let's ensure this works with a blank setup (empty APP_DATA/config.json) (cf. docs).
Suggested change
| label: this.options.state.closedTabs.length > 0 ? 'Reopen Last File' : 'No Files Opened', | |
| label: this.options.state.closedTabs?.length > 0 ? 'Reopen Last File' : 'No Files Opened', |
You can try to clear the Modeler application data and see the impact.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4119