Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tesla Model 3 / Model Y Car Port (Clean) #32331

Open
wants to merge 153 commits into
base: master
Choose a base branch
from

Conversation

lukasloetkolben
Copy link

@lukasloetkolben lukasloetkolben commented May 1, 2024

In a conversation with DebboR, we considered removing the Model S code from openpilot and adding a clean Model3 code instead. Here is an implementation with only Tesla Model 3/Y.

The best thing about this carport is that only a single bus had to be intercepted. 🎉
No external Panda is required, just a C3X and a harness box.

Checklist Model 3

  • added entry to CAR in selfdrive/car/tesla/values.py
  • test route added to routes.py
  • route with openpilot: b5f2b5b4ef23f4b6/00000008--d88c2210a5
  • route with stock system: b5f2b5b4ef23f4b6/00000009--f3a74d938c
  • car harness used (if comma doesn't sell it, put N/A): N/A

Checklist Model Y

  • added entry to CAR in selfdrive/car/tesla/values.py
  • test route added to routes.py
  • route with openpilot: 35f334fe58c5cdc5/00000089--c5ed862a40
  • route with stock system: 35f334fe58c5cdc5/00000001--d8d176b1af
  • car harness used (if comma doesn't sell it, put N/A): N/A

Tesla is in dashcam mode only, so Model 3 and Model Y will not yet appear in CARS.md or release notes.

Additional Routes for the other Fingerprints:
Model 3 2023 (RHD): 574d45dbc63e9fd8/00000000--0c80908e8c
Model 3 2023 (LHD): 8b67b428fd9fea5c/00000047--d04a4d7f8a
Model 3 2021 (LHD): 5df538ba7679f5b7/00000002--ab29e12a18
Model 3 2020 (LHD): be7997c2a9399899/00000001--9d87515889
Model Y 2022 (LHD): 58a1cdc98298efcb/00000000--166a842612
Model Y 2022 (RHD): 5313f747976147e6/00000015--c1fa5e2ce0
Model Y 2020 (LHD): 7588270b74f42d15/00000000--85ec85024a

Demos on Youtube:
https://www.youtube.com/watch?v=CwjCp1Gb9d4
https://www.youtube.com/watch?v=1rh0sfZPymE
https://www.youtube.com/watch?v=LC0k8hmkBus
https://www.youtube.com/watch?v=ljMDHocoxxM

@lukasloetkolben lukasloetkolben changed the title Tesla Model 3 / Model Y Car Port Tesla Model 3 / Model Y Car Port (Clean) May 1, 2024
@mattwebbio
Copy link
Contributor

Is there anything preventing this from being merged?

- same seatbelt signal for RHD & LHD
@adeebshihadeh
Copy link
Contributor

Is there anything preventing this from being merged?

This is a substantially new car port, which takes time to review.

@jayvin100
Copy link
Contributor

If i have the 2024 M3 Highland will this work? I assume just have to add the fingerprint once I get it plugged in right?

@lukasloetkolben
Copy link
Author

If i have the 2024 M3 Highland will this work? I assume just have to add the fingerprint once I get it plugged in right?

This is only for Model3 with HW3. The model3 Highland has HW4 at least has a different connector, I can't say anything about the software yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants