-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HKG: Hyundai Ioniq 5 N 2024 Car Port #32396
base: master
Are you sure you want to change the base?
Conversation
Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:
|
Can this car be kept inside the |
Is there a way to distinguish between regular ioniq5 and n in interface.py? Mass, wheelbase, and steerRatio are slightly different. |
The wheelbase looks identical (our 2.97 should be 2.99), mass differs due to the battery size (but it already doesn't match exactly for the various trims we support), so that all looks fine. If we can't detect that turn signal difference reliably, sounds like I didn't do any verification on it yet, then you can leave it as a separate platform. You should rebase before you perform any more changes. |
selfdrive/car/hyundai/values.py
Outdated
CANFD_RADAR_SCC_CAR = {CAR.GENESIS_GV70_1ST_GEN, CAR.KIA_SORENTO_4TH_GEN, CAR.GENESIS_GV80, CAR.KIA_CARNIVAL_4TH_GEN, CAR.KIA_SORENTO_HEV_4TH_GEN, | ||
CAR.IONIQ_5_N} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure this is correct?
You can add |
selfdrive/car/hyundai/carstate.py
Outdated
@@ -208,7 +208,7 @@ def update_canfd(self, cp, cp_cam): | |||
|
|||
# TODO: alt signal usage may be described by cp.vl['BLINKERS']['USE_ALT_LAMP'] | |||
left_blinker_sig, right_blinker_sig = "LEFT_LAMP", "RIGHT_LAMP" | |||
if self.CP.carFingerprint == CAR.HYUNDAI_KONA_EV_2ND_GEN: | |||
if bool(cp.vl['BLINKERS']['USE_ALT_LAMP']): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you make this a tuple check for the two cars? don't add a flag yet, as once we detect it, it won't require a flag
bebc456
to
b1d5d19
Compare
Just to add to the fingerprints, here's the fingerprint for the US |
fwdRadar is same? |
Yeah, |
Checklist
selfdrive/car/docs.py
to generate new docs78ad5150de133637/2024-05-09--03-49-06
Issues