-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attempt to improve CI setup-with-retry time with nix #32453
base: master
Are you sure you want to change the base?
Conversation
Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:
|
Would love to see if this is possible. I looked into this also but seemed like although nix is great it wouldn't help too much with cutting down the time. I hope I'm wrong though! |
Oh, why did it look like it wouldn't save time? The real issue is that I dont know whether nix is a technology that commaai would want to use since, while it is very beautiful and useful in some ways, it can be quite frustrating to work with unless you're super into the technology due to
If I can figure out a way to do this without forcing commaai to have to switch their entire stack to nix, that would be ideal(and what I'm hoping to do with dream2nix). |
I had the exact same thought of nix being able to get it under 20s no problem. They would take it as long as it's not overly complex. My attempt was to use https://github.com/cachix/cachix as it supports the use of it in GHA. It seems like nix would be perfect for this but from going through the docs it didn't come across as a solution to solve it since we'd still have to pull the cached binary (assuming we're using cachix) which wouldn't result in much time being saved, the time to pull an image is the bulk of the build when looking at jobs performed. But keep in mind this is with my knowledge of nix, I stopped investigating due to seeing it as not a solution for <20s. The docs aren't the greatest (and they're aware of that) so I could've totally missed something that would prove me wrong. I keep intending to get back to investigating at some point but get sidetracked by other opened issues that catch my interest. If you do get it i would love to learn how |
No description provided.