Fix crash when toggling on and off an account very fast (#1505) #1541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eerielili
force-pushed
the
fix-assertion-account-has-key
branch
from
e1d7363
to
d624a97
Compare
- The switch widget in the account managment dialog is now not accepting input while the account being enabled is connecting.
eerielili
force-pushed
the
fix-assertion-account-has-key
branch
from
d624a97
to
1ca0326
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should close #1505.
I tried clicking as soon as the switch becomes sensitive repeatedly and it doesn't crash anymore.
There's still some lines whining about:
dino_connection_manager_connection_reset: assertion 'self != NULL' failedbut it doesn't crash.