Make encryption status and icons more noticeable #1555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…parate color for OMEMO or PGP This commit is adressing dino#1240: - If you hover the encryption icon on your messages if present, it should now say "This message is PGP encrypted" or "This message is OMEMO encrypted". - As a visual aid, the icon's color change accordingly. PGP is blue-ish, OMEMO is off green-ish. - NOTE: There's no color if your theme's 'changes-prevent-symbolic' icon is not a SVG.
- added file changes-allow-symbolic from GTK Adwaita icon theme as dino-unencrypted.svg (licensed under LGPL3)
…ut box - also adresses dino#1240
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is about issue #1240, #971 and also #1345 I guess.
I've borrowed the changes-allow-symbolic from the Adwaita since it's simple and does the job and paint it red when unencrypted:
A message also appears in the chat input status label when you send unencrypted messages:
Here's messages' padlock color depending on encryption methods:
If you have encryption enabled when opening a chat, unencrypted messages will look like this :
If not no padlock will be displayed, I didn't change default behavior much in this part.
Guess I could meddle with
https://github.com/dino/dino/blob/master/main/src/ui/conversation_content_view/conversation_item_skeleton.vala#L158C1-L169C10
to only not show up in public groupchats where OMEMO is disabled is most cases, will see.
There's also a tooltip to the encryption picking icon so it tells you what kind is used. It's a nice to have imho as it's saving you a click if you want to check it:
