Open files/folder in the file explorer #1089
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this adds an option that will open a file explorer highlighting the file/folder selected. Still needs to be a little more careful on error handling
|
Tested on mac os (apple silicon) and windows as well. I haven't tested remote folders though. |
|
We should probably only use one of You implemented it a bit differently than expected - the alternative would be that the feature is an additional action in the folder menu at the top that opens the current workspace folder, not an action on every list item. But I guess we could have even both? The advantage of your implementation is that when opening a file/folder, it it already selected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix #1053.
This is a PR that's very similar to #868, using a slightly different crate (
opener) that has arevealcall and a MIT OR Apache-2.0 license.The implementation detail for this is here https://docs.rs/opener/latest/opener/fn.reveal.html
The
opencrate doesn't have this option afaik but having two crates doing very similar things is slightly redundantTested only on linux aarch64 for now (but should be supported on all platforms)