Add body color to gr.Accordion

[hannahblair]

Description

We've got a variable button_primary_text_color="white" in monochrome.py which causes the button text color in the Accordion to be white in monochrome themes. To prevent any breaking changes, I've set the text color in Accordion.svelte to body_text_color to fix this (as opposed to changing the value of that var). I can't see where this is an issue in other components at first glance.

Demo here

Closes: #8255

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Tests

1. PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests: bash scripts/run_all_tests.sh

2. You may need to run the linters: bash scripts/format_backend.sh and bash scripts/format_frontend.sh

[gradio-pr-bot]

🪼 branch checks and previews

•	Name	Status	URL
	Spaces	ready!	Spaces preview
	Website	ready!	Website preview
	Storybook	ready!	Storybook preview
🦄	Changes	detected!	Details

---

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/9848219b26d2ea569451bf596992800c41d08d1d/gradio-4.31.4-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@9848219b26d2ea569451bf596992800c41d08d1d#subdirectory=client/python"

[gradio-pr-bot]

🦄 change detected

This Pull Request includes changes to the following packages.

Package	Version
@gradio/accordion	patch
gradio	patch

• Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Add body color to gr.Accordion

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

• Maintainers can change the version label to modify the version bump.
• If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

[freddyaboulton]

This looks good but I think it'll probably break some user defined theme somewhere. Can we make this more tailored to the monochrome theme somehow? What came to my mind:

1. Add a accordion_text_color and accordion_text_color_dark prop to the theme class
2. By default, these prop values default to button_primary_text_color value
3. For monochrome, accordion_text_color is body_text_color

What do you think?

[aliabid94]

Demo is private @hannahblair

[aliabid94]

LGTM!

[pngwn]

Looks great. Thanks @hannahblair!

[hannahblair]

This looks good but I think it'll probably break some user defined theme somewhere. Can we make this more tailored to the monochrome theme somehow? What came to my mind:

1. Add a accordion_text_color and accordion_text_color_dark prop to the theme class
2. By default, these prop values default to button_primary_text_color value
3. For monochrome, accordion_text_color is body_text_color

What do you think?

thanks for the feedback! that's a good point. i've added a new accordion_text_color + -dark prop but we can't use the button_primary_text_color else we'll get this in light mode:

I've used body_text_color as the default, but this still creates a breaking change I think.

[freddyaboulton]

Thanks @hannahblair !