[WIP] Move image path to the session scope. #1866
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shohhei1126
changed the title
shohhei1126
force-pushed
the
image_sessesion
branch
from
2921fc0
to
2f824ff
Compare
Signed-off-by: shohhei1126 <shohheiitoh@gmail.com>
shohhei1126
force-pushed
the
image_sessesion
branch
from
2f824ff
to
973c735
Compare
|
Hi @shohhei1126, Thanks for opening PR! There is a use case that user uploads images in a note and later they like to reuse those image urls on the other platform (like external blog post or SNS) and those images will become inaccessible due to the session auth. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress for #1601