This repository has been archived by the owner on Feb 10, 2024. It is now read-only.
Apply font changes to server list #2264
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Prevent use of inflexible gtk_cell_renderer_text_set_fixed_height_from_font() (performance with lots of servers still seems good) * Redraw server list when applying setup See hexchat#2023
TingPing
reviewed
Oct 31, 2018
| cv_tree_queue_draw (chanview *cv) | ||
| { | ||
| /* assign the model again to cause the tree view to be redrawn | ||
| note: Simply using gtk_widget_queue_draw() is not sufficient. */ |
There was a problem hiding this comment.
This seems like a hacky workaround, I'd prefer figuring out a way to just tell it to redraw.
There was a problem hiding this comment.
I've looked at the documentation and tried several things before coming up with that hack. Do you have a specific API function in mind? I only found that function I mention in the comment but it is not sufficient because the layout is still not updated.
The preferred way for this to work is likely that GTK triggers the layout update itself if relevant properties like the font change. So doing things manually here will always be not the optimal solution and therefore a "hacky workaround".
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gtk_cell_renderer_text_set_fixed_height_from_font()
(performance with lots of servers still seems good)
See #2023
I'm aware this fixes only one of the lists in the issue. But I would like to wait for feedback first because it is my first time working GTK.